DATAREDIS-1151 - Provide an example of using scan as an option in RedisCache #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengchen
commented
Jul 10, 2020
| // | ||
| // if (keys.length > 0) { | ||
| // connection.del(keys); | ||
| // } |
There was a problem hiding this comment.
If this is a behavior change for you, maybe we could keep both and use a feature flag to toggle the choice?
chengchen
commented
Jul 10, 2020
|
|
||
| if (keys.length > 0) { | ||
| connection.del(keys); | ||
| int batchSize = 1000; // maybe make it configurable |
There was a problem hiding this comment.
If the user choose to use SCAN approach, we could let them configure this batch size as well, so that the Redis timeout option and batch delete size option are both in the hands of users.
chengchen
changed the title
mp911de
changed the title
spring-projects-issues
added
the
status: waiting-for-triage
rickgong
reviewed
Apr 8, 2021
| if (keys.length > 0) { | ||
| connection.del(keys); | ||
| int batchSize = 1000; // maybe make it configurable | ||
| ScanOptions options = ScanOptions.scanOptions().match(new String(pattern)).build(); |
There was a problem hiding this comment.
batchSize here seems not applied to ScanOptions
rickgong
reviewed
Apr 8, 2021
| keys[i] = cursor.next(); | ||
| } | ||
|
|
||
| connection.del(keys); |
There was a problem hiding this comment.
keys array may contains null element, which may fail DEL or UNLINK command.
Also, we can check if redis support UNLINK command.
private boolean isUnLinkSupported(RedisConnection redisConnection) {
if (unlinkSupported == null) {//private volatile Boolean unlinkSupported = null;
String smokingKey = "unlink-test" + System.currentTimeMillis() + UUID.randomUUID().toString();
try {
redisConnection.unlink(smokingKey.getBytes());
unlinkSupported = true;
} catch (RedisSystemException e) {
unlinkSupported = false;
}
}
return unlinkSupported;
}
mp911de
added
status: superseded
|
Usage of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I commented out the original implementation and added an example of using
SCAN.After a second thought, it might be reasonable to keep both and allow users to toggle the choice?