Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: Add C implementation for @stdlib/math/base/special/log10 #733

Closed
3 tasks done
Pranavchiku opened this issue Dec 17, 2022 · 2 comments · Fixed by #743
Closed
3 tasks done

[RFC]: Add C implementation for @stdlib/math/base/special/log10 #733

Pranavchiku opened this issue Dec 17, 2022 · 2 comments · Fixed by #743
Assignees
@Pranavchiku
Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 3 Likely to be challenging but manageable. Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.

Comments

@Pranavchiku
Copy link
Member

Description

This RFC proposes adding C implementation for @stdlib/math/base/special/log10.

double stdlib_base_log10( const double x );

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. RFC Request for comments. Feature requests and proposed changes. labels Dec 17, 2022
This was referenced Dec 20, 2022
Merged
Open
@kgryte kgryte added Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. and removed Feature Issue or pull request for adding a new feature. labels Dec 21, 2022
@Pratik772846
Copy link
Contributor

Hey, @kgryte @Planeshifter @Pranavchiku Can i work on this issue?

@kgryte
Copy link
Member

kgryte commented Mar 6, 2024

@Pratik772846 It looks like @Pranavchiku already has a WIP PR addressing this feature: #743. I think it best if we get that one over the finish line before opening a separate PR.

@kgryte kgryte added Accepted RFC feature request which has been accepted. priority: Normal Normal priority concern or feature request. difficulty: 3 Likely to be challenging but manageable. C Issue involves or relates to C. labels Mar 6, 2024
kgryte pushed a commit that referenced this issue Apr 27, 2024
@Pranavchiku
feat: add C implementation for math/base/special/log10
ededcf6 
PR-URL: #743
Closes: #733
Reviewed-by: Athan Reines <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
Co-authored-by: Athan Reines<[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pranavchiku Pranavchiku

Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 3 Likely to be challenging but manageable. Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add C implementation for math/base/special/log10 Pranavchiku/stdlib
3 participants
@kgryte @Pranavchiku @Pratik772846