Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for math/base/special/log10 #743

Merged
merged 20 commits into from
Apr 27, 2024
Merged

feat: add C implementation for math/base/special/log10 #743

merged 20 commits into from
Apr 27, 2024

Conversation

Pranavchiku
Copy link
Member

@Pranavchiku Pranavchiku commented Dec 20, 2022 •
edited
Loading

Resolves #733.

Checklist

  • update readme.md
  • include.gypi
  • binding.gyp
  • include/stdlib/math/base/special/
  • evalpoly.js
  • src
  • manifest.json
  • lib
  • examples
  • benchmark
  • test

@kgryte

@Pranavchiku
Copy link
Member Author

@kgryte I am not sure about implementation in main.c, if you can have a look.

@Pranavchiku Pranavchiku marked this pull request as ready for review December 20, 2022 05:46
@Pranavchiku
Copy link
Member Author

All tests and benchmarks cleared, this PR can have a review.

@kgryte kgryte added Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. labels Dec 25, 2022
@Planeshifter Planeshifter changed the title Add C implementation for @stdlib/math/base/special/log10 feat: add C implementation for math/base/special/log10 Mar 3, 2024
@kgryte kgryte mentioned this pull request Mar 6, 2024
Closed
3 tasks
@kgryte kgryte added the Needs Review A pull request which needs code review. label Mar 17, 2024
@kgryte kgryte self-requested a review March 17, 2024 10:14
Pranavchiku
Pranavchiku commented Apr 26, 2024
View reviewed changes
Copy link
Member Author

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kgryte I think this PR can have a final go through and this will then be ready to merge.

@Pranavchiku Pranavchiku added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Apr 26, 2024
Planeshifter
Planeshifter approved these changes Apr 27, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kgryte
kgryte approved these changes Apr 27, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kgryte kgryte added C Issue involves or relates to C. and removed Ready To Merge A pull request which is ready to be merged. labels Apr 27, 2024
@kgryte kgryte merged commit ededcf6 into stdlib-js:develop Apr 27, 2024
8 checks passed
@kgryte
Copy link
Member

kgryte commented Apr 27, 2024

@gunjjoshi Now that this is merged, would you be willing to migrate to msun 12.x?

@gunjjoshi
Copy link
Member

Yes @kgryte, I'll migrate the C implementation for this to msun 12.2.0 now.

@gunjjoshi
Copy link
Member

Made a PR for this at #2215.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/math/base/special/log10
4 participants
@Pranavchiku @kgryte @gunjjoshi @Planeshifter