-
-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC]: Add C implementation for @stdlib/math/base/special/spence
#894
Comments
I'd like to take this one on as well. |
Thanks, @Jordan-Gallivan, that would be great! |
@Jordan-Gallivan This implementation will be a touch more involved than your previous contributions. You can use Let us know if you have questions! |
Also, I'm happy to hop on a Google Meet to discuss further. |
@kgryte I definitely might need more coaching than the previous implementations but I think I'm up to the task. I'll comb through everything tonight and let you know if I have any questions before I jump in, in which case I'll definitely take you up on the Google Meet offer. |
Sounds good! Thanks for taking the initiative and working on this! |
@kgryte wanted to drop you a line and let you know that I'm still down to work this problem, I just got slammed last week with school/the internship search. |
@Jordan-Gallivan No worries! |
@kgryte just submitted a PR. You weren't kidding, this was a doozie. I added a few questions in the PR so please lemme know what I can fix. |
PR-URL: #2298 Closes: #894 Closes: #968 Ref: #649 Co-authored-by: Athan Reines <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Athan Reines <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]> Signed-off-by: Philipp Burckhardt <[email protected]> Signed-off-by: Athan Reines <[email protected]>
PR-URL: stdlib-js#2298 Closes: stdlib-js#894 Closes: stdlib-js#968 Ref: stdlib-js#649 Co-authored-by: Athan Reines <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Athan Reines <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]> Signed-off-by: Philipp Burckhardt <[email protected]> Signed-off-by: Athan Reines <[email protected]>
Description
This RFC proposes adding C implementation for
@stdlib/math/base/special/spence
.Related Issues
None.
Questions
No.
Other
No.
Checklist
RFC:
.The text was updated successfully, but these errors were encountered: