Skip to content
/ stdlib Public

  • Sponsor stdlib-js/stdlib

  • Notifications You must be signed in to change notification settings
  • Fork 775
  • Star 5k
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for math/base/special/spence #2298

Merged
merged 8 commits into from
Jun 7, 2024
Merged

feat: add C implementation for math/base/special/spence #2298

merged 8 commits into from
Jun 7, 2024
+1,469 −22

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Jun 3, 2024 •
edited
Loading

Resolves #894.

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

Sorry, something went wrong.

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Jun 3, 2024
@gunjjoshi
Copy link
Member Author

While implementing this, a bit higher tolerance was required in the tests. I checked the implementation with that of cephes, but it was the same.

@Planeshifter
Update lib/node_modules/@stdlib/math/base/special/spence/src/main.c

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
db4ddd3 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, will merge after CI checks have passed (updated @returns to @return in C function documentation.)

@kgryte
Apply suggestions from code review

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
2d4caf8 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte requested changes Jun 3, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this is good; however, we should investigate the test tolerance discrepancy before merging.

@kgryte kgryte added the C Issue involves or relates to C. label Jun 3, 2024
@kgryte
Copy link
Member

kgryte commented Jun 3, 2024

This PR also supersedes #968. Thus, once this PR is merged, the other PR should be closed.

kgryte added 4 commits June 6, 2024 18:41
@kgryte
docs: replace use of fancy quote

Verified

This commit was signed with the committer’s verified signature.
kgryte Athan
GPG key ID: 7691592D10721BD4
Verified
Learn about vigilant mode
Loading
Loading status checks…
0ac5db0
@kgryte
style: remove line breaks

Verified

This commit was signed with the committer’s verified signature.
kgryte Athan
GPG key ID: 7691592D10721BD4
Verified
Learn about vigilant mode
Loading
Loading status checks…
5633c07
@kgryte
refactor: create variable in parent scope and update test messages

Verified

This commit was signed with the committer’s verified signature.
kgryte Athan
GPG key ID: 7691592D10721BD4
Verified
Learn about vigilant mode
e6bc375
@kgryte
test: update test messages

Verified

This commit was signed with the committer’s verified signature.
kgryte Athan
GPG key ID: 7691592D10721BD4
Verified
Learn about vigilant mode
Loading
Loading status checks…
1f9cb76
kgryte
kgryte approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for working on this @gunjjoshi. I'll merge once CI passes.

@kgryte kgryte merged commit e382574 into stdlib-js:develop Jun 7, 2024
8 checks passed
@gunjjoshi gunjjoshi deleted the spence branch June 11, 2024 03:12
aman-095 pushed a commit to aman-095/stdlib that referenced this pull request Jun 13, 2024
@gunjjoshi @kgryte
@Planeshifter @aman-095
feat: add C implementation for math/base/special/spence
4170375 
PR-URL: stdlib-js#2298
Closes: stdlib-js#894
Closes: stdlib-js#968
Ref: stdlib-js#649
Co-authored-by: Athan Reines <kgryte@gmail.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Athan Reines <kgryte@gmail.com>
@Planeshifter Planeshifter mentioned this pull request Jun 19, 2024
Merged
1 task
kgryte added a commit that referenced this pull request Jul 17, 2024
@kgryte
refactor: use stdlib APIs and adjust test tolerances

Verified

This commit was signed with the committer’s verified signature.
kgryte Athan
GPG key ID: 7691592D10721BD4
Verified
Learn about vigilant mode
Loading
Loading status checks…
0d796b2 
Ref: #2298 (comment)
Ref: https://github.com/stdlib-js/stdlib/actions/runs/9967632974/job/27541607216
@gunjjoshi gunjjoshi mentioned this pull request Aug 11, 2024
Merged
1 task
@gunjjoshi gunjjoshi mentioned this pull request Nov 25, 2024
Merged
1 task
@anandkaranubc anandkaranubc mentioned this pull request Jan 22, 2025
Merged
1 task
@anandkaranubc anandkaranubc mentioned this pull request Feb 21, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter

@kgryte kgryte

Assignees
No one assigned
Labels
C Issue involves or relates to C. Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/math/base/special/spence
4 participants
@gunjjoshi @kgryte @Planeshifter @stdlib-bot