feat: add C implementation for math/base/special/spence
#968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Planeshifter
changed the title
math/base/special/spence
kgryte
added
Enhancement
|
Hey @Jordan-Gallivan, are you still working on this ? |
1 task
aman-095
pushed a commit
to aman-095/stdlib
that referenced
this pull request
Jun 13, 2024
PR-URL: stdlib-js#2298 Closes: stdlib-js#894 Closes: stdlib-js#968 Ref: stdlib-js#649 Co-authored-by: Athan Reines <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Athan Reines <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]> Signed-off-by: Philipp Burckhardt <[email protected]> Signed-off-by: Athan Reines <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #894
Description: C implementation of Spence's function
This pull request:
Related Issues
This pull request:
@stdlib/math/base/special/spence#894Questions
o There was some inconsistency in the .js files in terms of referring to this as "Spence's Function" or the Dilogarithm". Would you like me to keep a standard naming convention through out?
o while reasearching the evalpoly scripts, I noticed that some of the other functions that utilize cephes scripts do not have a c/native sub folder. I added one because the Ln() function does. I can easily delete it if it's not necessary
o For the test.native.js, I again referenced Ln()/. Do that file goes from big numbers to small numbers, but the test.js in spence goes from small to big. Which would you prefer?
o what commands do I need to execute to run the evalpoly script (to build in the polyval_a and polyval_b methods in the main.c file?
Other
No.
Checklist
@stdlib-js/reviewers