Skip to content

feat: add C implementation for math/base/special/round2 #2537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Jul 8, 2024

Description

What is the purpose of this pull request?

This pull request:

double stdlib_base_round2( const double x );

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

  • I was getting errors such as conflict in already defined variables in header files for HUGE. Also, there was a problem in calculating the value of the constants at compile time. That's why, I have made changes in the variable name, and have calculated it inside the function.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Sorry, something went wrong.

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Jul 8, 2024
@kgryte
Copy link
Member

kgryte commented Jul 8, 2024

Renaming HUGE was the right thing to do, so no issues there.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good; let's get it in!

@Planeshifter Planeshifter merged commit efc3551 into stdlib-js:develop Jul 8, 2024
8 checks passed
@gunjjoshi gunjjoshi deleted the round2 branch August 21, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Math Issue or pull request specific to math functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants