-
-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add C implementation for math/base/special/roundb
#2544
Conversation
@gunjjoshi Would it make more sense to make |
Sure @kgryte, I will change that. |
@kgryte, Do we have Edit: checked it, we don't have this. |
Should I add |
@gunjjoshi Yes, that would be great! |
I believe you'll also need to add a corresponding macro to that same package. |
Yes. I'll add the macro in the |
PR-URL: #2546 Ref: #2544 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Athan Reines <[email protected]>
@kgryte Our |
As discussed offline, the plan here is to remove non-applicable tests for the native bindings for |
Signed-off-by: GUNJ JOSHI <[email protected]>
Signed-off-by: GUNJ JOSHI <[email protected]>
Signed-off-by: GUNJ JOSHI <[email protected]>
Signed-off-by: GUNJ JOSHI <[email protected]>
Signed-off-by: GUNJ JOSHI <[email protected]>
I have also removed the checks in |
lib/node_modules/@stdlib/math/base/special/roundb/examples/c/example.c
Outdated
Show resolved
Hide resolved
Signed-off-by: Philipp Burckhardt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @gunjjoshi! Will merge once CI passes.
Description
This pull request:
math/base/special/roundb
.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers