Skip to content

feat: add C implementation for math/base/special/truncn #2569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 13, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Jul 12, 2024

Description

What is the purpose of this pull request?

This pull request:

double stdlib_base_truncn( const double x, const int32_t n );

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Similar to what we did in roundb, I have remove some test cases here too, which were not applicable.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Sorry, something went wrong.

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Jul 12, 2024
@Planeshifter Planeshifter self-requested a review July 13, 2024 15:55
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Jul 13, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small request, otherwise this looks great!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@Planeshifter Planeshifter merged commit e8932ee into stdlib-js:develop Jul 13, 2024
8 checks passed
@gunjjoshi gunjjoshi deleted the truncn branch August 21, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants