Skip to content
/ stdlib Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for math/base/special/binomcoef #2729

Merged
merged 8 commits into from
Aug 2, 2024
Merged

feat: add C implementation for math/base/special/binomcoef #2729

merged 8 commits into from
Aug 2, 2024
+1,387 −0

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Aug 2, 2024 •
edited
Loading

Resolves #2206.

Description

What is the purpose of this pull request?

This pull request:

double stdlib_base_binomcoef( const int64_t n, const int64_t k )

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

Sorry, something went wrong.

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Aug 2, 2024
@gunjjoshi
style: fix indentation in manifest.json
Loading
Loading status checks…
0f63d30
@gunjjoshi
style: fix indentation in main.c
Loading
Loading status checks…
faff658
@gunjjoshi gunjjoshi changed the title fear: add C implementation for math/base/special/binomcoef feat: add C implementation for math/base/special/binomcoef Aug 2, 2024
@gunjjoshi
Copy link
Member Author

I have excluded the tests to check when the input in either NaN or is not an integer, as stdlib_base_is_nan and stdlib_base_is_integer require inputs of double type, but here we're dealing with int64_t.

@gunjjoshi
Copy link
Member Author

I've fixed the PR title, but still the check is failing.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. C Issue involves or relates to C. labels Aug 2, 2024
@kgryte
Copy link
Member

kgryte commented Aug 2, 2024

@gunjjoshi Try merging in the latest develop and pushing that up. For whatever reason, GitHub is not pulling in the update title.

@gunjjoshi
Merge branch 'stdlib-js:develop' into binomcoef

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
9b123cc
@Planeshifter Planeshifter self-requested a review August 2, 2024 12:47
Planeshifter
Planeshifter requested changes Aug 2, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor concern, but otherwise should be ready to land!

@gunjjoshi
docs: remove cbrt from manifest.json

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
5203b62 
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
Planeshifter
Planeshifter approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge after CI has passed!

@Planeshifter Planeshifter merged commit 06b8011 into stdlib-js:develop Aug 2, 2024
10 checks passed
@gunjjoshi gunjjoshi deleted the binomcoef branch August 3, 2024 00:55
gunjjoshi added a commit to gunjjoshi/stdlib that referenced this pull request Aug 21, 2024
@gunjjoshi
feat: add C implementation for math/base/special/binomcoef
0c557a7 
PR-URL: stdlib-js#2729
Ref: stdlib-js#649

---------

Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add C implementation for math/base/special/binomcoef
4 participants
@gunjjoshi @kgryte @Planeshifter @stdlib-bot