Bug fix: Put the datatypes defined inside Python prelude on the top of Laurel Prelude.#618
Closed
thanhnguyen-aws wants to merge 12 commits intostrata-org:mainfrom
Closed
Bug fix: Put the datatypes defined inside Python prelude on the top of Laurel Prelude.#618thanhnguyen-aws wants to merge 12 commits intostrata-org:mainfrom
thanhnguyen-aws wants to merge 12 commits intostrata-org:mainfrom
Conversation
Co-authored-by: Joe Hendrix <joe.d.hendrix@gmail.com>
Co-authored-by: Joe Hendrix <joe.d.hendrix@gmail.com>
Co-authored-by: Joe Hendrix <joe.d.hendrix@gmail.com>
thanhnguyen-aws
requested review from
fabiomadge and
keyboardDrummer
as code owners
Contributor
|
Could you add a test for this? |
keyboardDrummer
requested changes
Mar 20, 2026
Contributor
There was a problem hiding this comment.
I don't think this change is right. The current setup allows anything in the Core part of the prelude to refer to the Laurel part of the prelude, but not the other way around. I think that is sufficient.
If there's a definition in the Core part of the prelude that you want to refer to from the Laurel prelude part, you should include that definition in the Laurel prelude as well.
Contributor
Author
|
Replaced by: #630 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 21, 2026
*Description of changes:* This PR adds collectTypeRefs for TCore, which fix the bug of unrecognized dependency between Box and Any. Thanks @keyboardDrummer. This PR replaces #618 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes: This PR put the datatypes defined inside Python prelude on the top of Laurel Prelude. This fixes the type-checking error when adding Box constructor/destructor for Any type.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.