Add collectTypeRefs for TCore#630
Merged
aqjune-aws merged 8 commits intostrata-org:mainfrom Mar 21, 2026
Merged
Conversation
thanhnguyen-aws
requested review from
fabiomadge and
keyboardDrummer
as code owners
shigoel
reviewed
Mar 20, 2026
shigoel
previously approved these changes
Mar 20, 2026
Contributor
|
Looks great. Could you add a regression test that shows the bug is fixed? |
shigoel
approved these changes
Mar 20, 2026
aqjune-aws
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes: This PR adds collectTypeRefs for TCore, which fix the bug of unrecognized dependency between Box and Any.
Thanks @keyboardDrummer.
This PR replaces #618
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.