Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename pool_signature field of channel_factory into additional_coinbase_script_data, and change the type from String to Vec<u8> #1442

Merged
merged 2 commits into from
Feb 18, 2025

change type of additional_coinbase_script_data to Vec<u8>

08b2523
Select commit
Loading
Failed to load commit list.
Merged

Rename pool_signature field of channel_factory into additional_coinbase_script_data, and change the type from String to Vec<u8> #1442

change type of additional_coinbase_script_data to Vec<u8>
08b2523
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 17, 2025 in 1s

18.27% (-0.02%) compared to 7dd1846

View this Pull Request on Codecov

18.27% (-0.02%) compared to 7dd1846

Details

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 18.27%. Comparing base (7dd1846) to head (08b2523).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
roles/jd-client/src/lib/upstream_sv2/upstream.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1442      +/-   ##
==========================================
- Coverage   18.28%   18.27%   -0.02%     
==========================================
  Files         127      127              
  Lines        9738     9738              
==========================================
- Hits         1781     1780       -1     
- Misses       7957     7958       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.