This repository was archived by the owner on Mar 7, 2019. It is now read-only.
feat: use @typescript-eslint for TypeScript rules #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| '@typescript-eslint/member-delimiter-style': ['warn', { | ||
| multiline: { | ||
| delimiter: 'none', | ||
| requireLast: false |
There was a problem hiding this comment.
Is this change necessary in order to switch the packages or is this a rule change suggestion? 😇 If it is the latter I would prefer to have it in a separate PR so we can discuss the change with the whole team. 🙏
There was a problem hiding this comment.
It's a necessary change. It should behave in the same way as before 😇
robertrossmann
suggested changes
Jan 29, 2019
honzahovorka
force-pushed
the
feature/typescript-eslint
branch
from
048096e to
8bc7f7d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since eslint/typescript-eslint-parser is deprecated, let's use @typescript-eslint/parser instead.