Address review comments #981
Annotations
10 errors and 1 warning
|
Publish Test Report:
clients/da-vinci-client/src/test/java/com/linkedin/davinci/kafka/consumer/KafkaConsumerServiceDelegatorTest.java#L353
java.lang.AssertionError: expected [true] but found [false]
|
|
Publish Test Report:
clients/da-vinci-client/src/test/java/com/linkedin/davinci/repository/NativeMetadataRepositoryTest.java#L149
java.lang.AssertionError: expected [2000.0] but found [1000.0]
|
|
Publish Test Report:
clients/da-vinci-client/src/test/java/com/linkedin/davinci/kafka/consumer/SITWithSAwarePWiseWithoutBufferAfterLeaderTest.java#L1
Wanted but not invoked:
abstractStorageEngine.put(
1,
[(byte) 0x01, (byte) 0x4B, (byte) 0x65, (byte) 0x79, (byte) 0x46, (byte) 0x6F, (byte) 0x72, (byte) 0x50, (byte) 0x61, (byte) 0x72, (byte) 0x74, (byte) 0x69, (byte) 0x74, (byte) 0x69, (byte) 0x6F, (byte) 0x6E, (byte) 0x31, (byte) 0x5F, (byte) 0x31, (byte) 0x66, (byte) 0x37, (byte) 0x32, (byte) 0x66, (byte) 0x31, (byte) 0x64, (byte) 0x61, (byte) 0x31, (byte) 0x62, (byte) 0x5F, (byte) 0x64, (byte) 0x66, (byte) 0x31, (byte) 0x36, (byte) 0x66, (byte) 0x64, (byte) 0x30, (byte) 0x36],
java.nio.HeapByteBuffer[pos=0 lim=17 cap=17]
);
-> at com.linkedin.davinci.store.AbstractStorageEngine.put(AbstractStorageEngine.java:478)
However, there was exactly 1 interaction with this mock:
abstractStorageEngine.getStoreVersionState();
-> at com.linkedin.davinci.store.DelegatingStorageEngine.getStoreVersionState(DelegatingStorageEngine.java:274)
|
|
Publish Test Report:
clients/da-vinci-client/src/test/java/com/linkedin/davinci/kafka/consumer/SITWithSAwarePWiseWithoutBufferAfterLeaderTest.java#L1
java.util.concurrent.TimeoutException
|
|
Publish Test Report:
clients/da-vinci-client/src/test/java/com/linkedin/davinci/kafka/consumer/SITWithSAwarePWiseWithoutBufferAfterLeaderTest.java#L1
java.util.concurrent.TimeoutException
|
|
Publish Test Report:
clients/da-vinci-client/src/test/java/com/linkedin/davinci/kafka/consumer/SITWithSAwarePWiseWithoutBufferAfterLeaderTest.java#L1
java.util.concurrent.TimeoutException
|
|
Publish Test Report:
clients/da-vinci-client/src/test/java/com/linkedin/davinci/kafka/consumer/SITWithSAwarePWiseWithoutBufferAfterLeaderTest.java#L1
java.util.concurrent.TimeoutException
|
|
Publish Test Report:
clients/da-vinci-client/src/test/java/com/linkedin/davinci/kafka/consumer/SITWithSAwarePWiseWithoutBufferAfterLeaderTest.java#L1
org.mockito.exceptions.misusing.UnfinishedStubbingException:
Unfinished stubbing detected here:
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTaskTest.lambda$testReportIfCatchUpVersionTopicOffset$185(StoreIngestionTaskTest.java:6194)
E.g. thenReturn() may be missing.
Examples of correct stubbing:
when(mock.isOk()).thenReturn(true);
when(mock.isOk()).thenThrow(exception);
doThrow(exception).when(mock).someVoidMethod();
Hints:
1. missing thenReturn()
2. you are trying to stub a final method, which is not supported
3. you are stubbing the behaviour of another mock inside before 'thenReturn' instruction is completed
|
|
Publish Test Report:
clients/da-vinci-client/src/test/java/com/linkedin/davinci/kafka/consumer/SITWithSAwarePWiseAndBufferAfterLeaderTest.java#L1
org.mockito.exceptions.verification.TooFewActualInvocations:
hostLevelIngestionStats.recordTotalBytesConsumed(
<any long>
);
Wanted 2 times:
-> at com.linkedin.davinci.stats.HostLevelIngestionStats.recordTotalBytesConsumed(HostLevelIngestionStats.java:507)
But was 1 time:
-> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerRecord(StoreIngestionTask.java:2740)
|
|
Publish Test Report:
clients/da-vinci-client/src/test/java/com/linkedin/davinci/kafka/consumer/KafkaConsumerServiceDelegatorTest.java#L353
java.lang.AssertionError: expected [true] but found [false]
|
|
Upload Build Artifacts
Retention days cannot be greater than the maximum allowed retention set within the repository. Using 10 instead.
|
Loading