Address review comments #981
Annotations
2 errors and 1 warning
|
Publish Test Report:
services/venice-controller/src/test/java/com/linkedin/venice/controller/TestVeniceParentHelixAdminWithAcl.java#L144
org.mockito.exceptions.misusing.UnfinishedStubbingException:
Unfinished stubbing detected here:
-> at com.linkedin.venice.controller.TestVeniceParentHelixAdminWithAcl.testUpdateAndGetAndDeleteAcl(TestVeniceParentHelixAdminWithAcl.java:144)
E.g. thenReturn() may be missing.
Examples of correct stubbing:
when(mock.isOk()).thenReturn(true);
when(mock.isOk()).thenThrow(exception);
doThrow(exception).when(mock).someVoidMethod();
Hints:
1. missing thenReturn()
2. you are trying to stub a final method, which is not supported
3. you are stubbing the behaviour of another mock inside before 'thenReturn' instruction is completed
|
|
Publish Test Report:
services/venice-controller/src/test/java/com/linkedin/venice/controller/TestVeniceParentHelixAdminWithAcl.java#L144
org.mockito.exceptions.misusing.UnfinishedStubbingException:
Unfinished stubbing detected here:
-> at com.linkedin.venice.controller.TestVeniceParentHelixAdminWithAcl.testUpdateAndGetAndDeleteAcl(TestVeniceParentHelixAdminWithAcl.java:144)
E.g. thenReturn() may be missing.
Examples of correct stubbing:
when(mock.isOk()).thenReturn(true);
when(mock.isOk()).thenThrow(exception);
doThrow(exception).when(mock).someVoidMethod();
Hints:
1. missing thenReturn()
2. you are trying to stub a final method, which is not supported
3. you are stubbing the behaviour of another mock inside before 'thenReturn' instruction is completed
|
|
Upload Build Artifacts
Retention days cannot be greater than the maximum allowed retention set within the repository. Using 10 instead.
|
Loading