Skip to content

Address review comments #946

Address review comments

Address review comments #946

GitHub Actions / IntegrationTests_14 Test Reports succeeded Nov 22, 2025 in 0s

52 passed, 2 failed and 0 skipped

Tests failed

Report Passed Failed Skipped Time
IntegrationTests_14-artifacts/internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.controller.kafka.consumer.AdminConsumptionTaskIntegrationTest.xml 5✅ 42s
IntegrationTests_14-artifacts/internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.endToEnd.TestPartialUpdateWithActiveActiveReplication.xml 4✅ 133s
IntegrationTests_14-artifacts/internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.helix.TestHelixReadOnlyStorageEngineRepository.xml 3✅ 6s
IntegrationTests_14-artifacts/internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.helix.TestHelixReadWriteStorageEngineRepository.xml 4✅ 893ms
IntegrationTests_14-artifacts/internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.helixrebalance.LeaderFollowerThreadPoolTest.xml 2✅ 1❌ 745s
IntegrationTests_14-artifacts/internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.ingestionHeartbeat.IngestionHeartBeatTest.xml 4✅ 136s
IntegrationTests_14-artifacts/internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.pubsub.manager.TopicManagerE2ETest.xml 4✅ 204s
internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.controller.kafka.consumer.AdminConsumptionTaskIntegrationTest.xml 5✅ 42s
internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.endToEnd.TestPartialUpdateWithActiveActiveReplication.xml 4✅ 133s
internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.helix.TestHelixReadOnlyStorageEngineRepository.xml 3✅ 6s
internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.helix.TestHelixReadWriteStorageEngineRepository.xml 4✅ 893ms
internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.helixrebalance.LeaderFollowerThreadPoolTest.xml 2✅ 1❌ 745s
internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.ingestionHeartbeat.IngestionHeartBeatTest.xml 4✅ 136s
internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.pubsub.manager.TopicManagerE2ETest.xml 4✅ 204s

✅ IntegrationTests_14-artifacts/internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.controller.kafka.consumer.AdminConsumptionTaskIntegrationTest.xml

5 tests were completed in 42s with 5 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.controller.kafka.consumer.AdminConsumptionTaskIntegrationTest 5✅ 42s

✅ com.linkedin.venice.controller.kafka.consumer.AdminConsumptionTaskIntegrationTest

✅ testAdminConsumptionTaskWithSpecificWriterId
✅ testParallelAdminExecutionTasks
✅ testSkipMessageEndToEnd
✅ testSkipMessageWithExecutionIdEndToEnd
✅ testUpdateAdminOperationVersion

✅ IntegrationTests_14-artifacts/internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.endToEnd.TestPartialUpdateWithActiveActiveReplication.xml

4 tests were completed in 133s with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.endToEnd.TestPartialUpdateWithActiveActiveReplication 4✅ 133s

✅ com.linkedin.venice.endToEnd.TestPartialUpdateWithActiveActiveReplication

✅ testAAReplicationForPartialUpdateOnFields
✅ testAAReplicationForPartialUpdateOnListField
✅ testAAReplicationForPartialUpdateOnMapField
✅ testActiveActivePartialUpdateWithRecordMapField

✅ IntegrationTests_14-artifacts/internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.helix.TestHelixReadOnlyStorageEngineRepository.xml

3 tests were completed in 6s with 3 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.helix.TestHelixReadOnlyStorageEngineRepository 3✅ 6s

✅ com.linkedin.venice.helix.TestHelixReadOnlyStorageEngineRepository

✅ testGetStore
✅ testLoadFromZK
✅ testNotifiers

✅ IntegrationTests_14-artifacts/internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.helix.TestHelixReadWriteStorageEngineRepository.xml

4 tests were completed in 893ms with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.helix.TestHelixReadWriteStorageEngineRepository 4✅ 893ms

✅ com.linkedin.venice.helix.TestHelixReadWriteStorageEngineRepository

✅ testAddAndDeleteStore
✅ testAddAndReadStore
✅ testLoadFromZK
✅ testUpdateAndReadStore

❌ IntegrationTests_14-artifacts/internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.helixrebalance.LeaderFollowerThreadPoolTest.xml

3 tests were completed in 745s with 2 passed, 1 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.helixrebalance.LeaderFollowerThreadPoolTest 2✅ 1❌ 745s

❌ com.linkedin.venice.helixrebalance.LeaderFollowerThreadPoolTest

✅ testLeaderFollowerDualThreadPool
❌ testLeaderFollowerSingleThreadPool
	java.lang.AssertionError: expected [true] but found [false]
✅ testLeaderFollowerSingleThreadPool

✅ IntegrationTests_14-artifacts/internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.ingestionHeartbeat.IngestionHeartBeatTest.xml

4 tests were completed in 136s with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.ingestionHeartbeat.IngestionHeartBeatTest 4✅ 136s

✅ com.linkedin.venice.ingestionHeartbeat.IngestionHeartBeatTest

✅ testIngestionHeartBeat[0](false, false)
✅ testIngestionHeartBeat[2](true, false)
✅ testIngestionHeartBeat[4](false, true)
✅ testIngestionHeartBeat[6](true, true)

✅ IntegrationTests_14-artifacts/internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.pubsub.manager.TopicManagerE2ETest.xml

4 tests were completed in 204s with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.pubsub.manager.TopicManagerE2ETest 4✅ 204s

✅ com.linkedin.venice.pubsub.manager.TopicManagerE2ETest

✅ testClose
✅ testConcurrentApiExecution
✅ testMetadataApisForExistingTopics
✅ testMetadataApisForNonExistentTopics

✅ internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.controller.kafka.consumer.AdminConsumptionTaskIntegrationTest.xml

5 tests were completed in 42s with 5 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.controller.kafka.consumer.AdminConsumptionTaskIntegrationTest 5✅ 42s

✅ com.linkedin.venice.controller.kafka.consumer.AdminConsumptionTaskIntegrationTest

✅ testAdminConsumptionTaskWithSpecificWriterId
✅ testParallelAdminExecutionTasks
✅ testSkipMessageEndToEnd
✅ testSkipMessageWithExecutionIdEndToEnd
✅ testUpdateAdminOperationVersion

✅ internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.endToEnd.TestPartialUpdateWithActiveActiveReplication.xml

4 tests were completed in 133s with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.endToEnd.TestPartialUpdateWithActiveActiveReplication 4✅ 133s

✅ com.linkedin.venice.endToEnd.TestPartialUpdateWithActiveActiveReplication

✅ testAAReplicationForPartialUpdateOnFields
✅ testAAReplicationForPartialUpdateOnListField
✅ testAAReplicationForPartialUpdateOnMapField
✅ testActiveActivePartialUpdateWithRecordMapField

✅ internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.helix.TestHelixReadOnlyStorageEngineRepository.xml

3 tests were completed in 6s with 3 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.helix.TestHelixReadOnlyStorageEngineRepository 3✅ 6s

✅ com.linkedin.venice.helix.TestHelixReadOnlyStorageEngineRepository

✅ testGetStore
✅ testLoadFromZK
✅ testNotifiers

✅ internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.helix.TestHelixReadWriteStorageEngineRepository.xml

4 tests were completed in 893ms with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.helix.TestHelixReadWriteStorageEngineRepository 4✅ 893ms

✅ com.linkedin.venice.helix.TestHelixReadWriteStorageEngineRepository

✅ testAddAndDeleteStore
✅ testAddAndReadStore
✅ testLoadFromZK
✅ testUpdateAndReadStore

❌ internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.helixrebalance.LeaderFollowerThreadPoolTest.xml

3 tests were completed in 745s with 2 passed, 1 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.helixrebalance.LeaderFollowerThreadPoolTest 2✅ 1❌ 745s

❌ com.linkedin.venice.helixrebalance.LeaderFollowerThreadPoolTest

✅ testLeaderFollowerDualThreadPool
❌ testLeaderFollowerSingleThreadPool
	java.lang.AssertionError: expected [true] but found [false]
✅ testLeaderFollowerSingleThreadPool

✅ internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.ingestionHeartbeat.IngestionHeartBeatTest.xml

4 tests were completed in 136s with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.ingestionHeartbeat.IngestionHeartBeatTest 4✅ 136s

✅ com.linkedin.venice.ingestionHeartbeat.IngestionHeartBeatTest

✅ testIngestionHeartBeat[0](false, false)
✅ testIngestionHeartBeat[2](true, false)
✅ testIngestionHeartBeat[4](false, true)
✅ testIngestionHeartBeat[6](true, true)

✅ internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.pubsub.manager.TopicManagerE2ETest.xml

4 tests were completed in 204s with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.pubsub.manager.TopicManagerE2ETest 4✅ 204s

✅ com.linkedin.venice.pubsub.manager.TopicManagerE2ETest

✅ testClose
✅ testConcurrentApiExecution
✅ testMetadataApisForExistingTopics
✅ testMetadataApisForNonExistentTopics

Annotations

Check failure on line 119 in internal/venice-test-common/src/integrationTest/java/com/linkedin/venice/helixrebalance/LeaderFollowerThreadPoolTest.java

See this annotation in the file changed.

@github-actions github-actions / IntegrationTests_14 Test Reports

com.linkedin.venice.helixrebalance.LeaderFollowerThreadPoolTest ► testLeaderFollowerSingleThreadPool

Failed test found in:
  IntegrationTests_14-artifacts/internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.helixrebalance.LeaderFollowerThreadPoolTest.xml
  internal/venice-test-common/build/test-results/integrationTests_14/TEST-com.linkedin.venice.helixrebalance.LeaderFollowerThreadPoolTest.xml
Error:
  java.lang.AssertionError: expected [true] but found [false]
Raw output
java.lang.AssertionError: expected [true] but found [false]
	at org.testng.Assert.fail(Assert.java:96)
	at org.testng.Assert.failNotEquals(Assert.java:776)
	at org.testng.Assert.assertTrue(Assert.java:44)
	at org.testng.Assert.assertTrue(Assert.java:54)
	at com.linkedin.venice.helixrebalance.LeaderFollowerThreadPoolTest.testLeaderFollowerSingleThreadPool(LeaderFollowerThreadPoolTest.java:119)