Skip to content

Address review comments #946

Address review comments

Address review comments #946

GitHub Actions / IntegrationTests_11 Test Reports succeeded Nov 22, 2025 in 1s

148 passed, 0 failed and 0 skipped

Tests passed successfully

Report Passed Failed Skipped Time
IntegrationTests_11-artifacts/internal/venice-test-common/build/test-results/integrationTests_11/TEST-com.linkedin.venice.client.store.TestSslTransportClient.xml 2✅ 9s
IntegrationTests_11-artifacts/internal/venice-test-common/build/test-results/integrationTests_11/TEST-com.linkedin.venice.controller.server.TestAdminSparkServer.xml 39✅ 303s
IntegrationTests_11-artifacts/internal/venice-test-common/build/test-results/integrationTests_11/TEST-com.linkedin.venice.controller.TestDelayedRebalance.xml 5✅ 138s
IntegrationTests_11-artifacts/internal/venice-test-common/build/test-results/integrationTests_11/TEST-com.linkedin.venice.controller.VeniceParentHelixAdminTest.xml 8✅ 455s
IntegrationTests_11-artifacts/internal/venice-test-common/build/test-results/integrationTests_11/TEST-com.linkedin.venice.endToEnd.TestHybrid.xml 12✅ 289s
IntegrationTests_11-artifacts/internal/venice-test-common/build/test-results/integrationTests_11/TEST-com.linkedin.venice.helix.TestHelixReadOnlyStoreRepositoryAdapter.xml 8✅ 1s
internal/venice-test-common/build/test-results/integrationTests_11/TEST-com.linkedin.venice.client.store.TestSslTransportClient.xml 2✅ 9s
internal/venice-test-common/build/test-results/integrationTests_11/TEST-com.linkedin.venice.controller.server.TestAdminSparkServer.xml 39✅ 303s
internal/venice-test-common/build/test-results/integrationTests_11/TEST-com.linkedin.venice.controller.TestDelayedRebalance.xml 5✅ 138s
internal/venice-test-common/build/test-results/integrationTests_11/TEST-com.linkedin.venice.controller.VeniceParentHelixAdminTest.xml 8✅ 455s
internal/venice-test-common/build/test-results/integrationTests_11/TEST-com.linkedin.venice.endToEnd.TestHybrid.xml 12✅ 289s
internal/venice-test-common/build/test-results/integrationTests_11/TEST-com.linkedin.venice.helix.TestHelixReadOnlyStoreRepositoryAdapter.xml 8✅ 1s

✅ IntegrationTests_11-artifacts/internal/venice-test-common/build/test-results/integrationTests_11/TEST-com.linkedin.venice.client.store.TestSslTransportClient.xml

2 tests were completed in 9s with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.client.store.TestSslTransportClient 2✅ 9s

✅ com.linkedin.venice.client.store.TestSslTransportClient

✅ testSslTransportClientCanTalkToRouter[0](master_controller)
✅ testSslTransportClientCanTalkToRouter[1](leader_controller)

✅ IntegrationTests_11-artifacts/internal/venice-test-common/build/test-results/integrationTests_11/TEST-com.linkedin.venice.controller.server.TestAdminSparkServer.xml

39 tests were completed in 303s with 39 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.controller.server.TestAdminSparkServer 39✅ 303s

✅ com.linkedin.venice.controller.server.TestAdminSparkServer

✅ canCreateAHybridStore
✅ controllerCanGetDeletableStoreTopics
✅ controllerCanHandleLargePayload
✅ controllerClientCanCreateNewStore
✅ controllerClientCanDeleteAllVersion
✅ controllerClientCanDeleteOldVersion
✅ controllerClientCanDeleteStore
✅ controllerClientCanDisableStoresRead
✅ controllerClientCanDisableStoresReadWrite
✅ controllerClientCanDisableStoresWrite
✅ controllerClientCanDiscoverCluster
✅ controllerClientCanEnableMaxCapacityProtection
✅ controllerClientCanEnableThrottling
✅ controllerClientCanGetExecutionOfDeleteAllVersions
✅ controllerClientCanGetExecutionOfDeleteStore
✅ controllerClientCanGetLastSucceedExecutionId
✅ controllerClientCanGetStorageEngineOverheadRatio
✅ controllerClientCanGetStoreInfo
✅ controllerClientCanListFutureStoreVersions
✅ controllerClientCanListStoresStatuses
✅ controllerClientCanNotAutoMigrateStore
✅ controllerClientCanNotDeleteStore
✅ controllerClientCanQueryInstanceStatusInCluster
✅ controllerClientCanQueryNodesInCluster
✅ controllerClientCanQueryRemovability
✅ controllerClientCanQueryReplicasForTopic
✅ controllerClientCanQueryReplicasOnAStorageNode
✅ controllerClientCanSetStore
✅ controllerClientCanSetStoreMetadata
✅ controllerClientCanSetStoreMissingSomeFields
✅ controllerClientCanUpdateAllowList
✅ controllerClientGetKeySchema
✅ controllerClientManageValueSchema
✅ controllerClientProvidesErrorWhenRequestingTopicForStoreThatDoesNotExist
✅ controllerClientReturns404ForNonexistentStoreQuery
✅ controllerClientSchemaOperationsAgainstInvalidStore
✅ testAggregatedHealthStatusCall
✅ testCleanupInstanceCustomizedStates
✅ testDeleteKafkaTopic

✅ IntegrationTests_11-artifacts/internal/venice-test-common/build/test-results/integrationTests_11/TEST-com.linkedin.venice.controller.TestDelayedRebalance.xml

5 tests were completed in 138s with 5 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.controller.TestDelayedRebalance 5✅ 138s

✅ com.linkedin.venice.controller.TestDelayedRebalance

✅ testDisableRebalanceTemporarily
✅ testEnableDelayedRebalance
✅ testFailOneServerWithDelayedRebalance
✅ testFailOneServerWithDelayedRebalanceTimeout
✅ testModifyDelayedRebalanceTime

✅ IntegrationTests_11-artifacts/internal/venice-test-common/build/test-results/integrationTests_11/TEST-com.linkedin.venice.controller.VeniceParentHelixAdminTest.xml

8 tests were completed in 455s with 8 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.controller.VeniceParentHelixAdminTest 8✅ 455s

✅ com.linkedin.venice.controller.VeniceParentHelixAdminTest

✅ testAddVersion
✅ testHybridAndETLStoreConfig
✅ testResourceCleanupCheckForStoreRecreation
✅ testRollbackToBackupVersion
✅ testStoreMetaDataUpdateFromParentToChildController[0](true, true)
✅ testStoreMetaDataUpdateFromParentToChildController[2](false, false)
✅ testSupersetSchemaWithCustomSupersetSchemaGenerator
✅ testTerminalStateTopicChecker

✅ IntegrationTests_11-artifacts/internal/venice-test-common/build/test-results/integrationTests_11/TEST-com.linkedin.venice.endToEnd.TestHybrid.xml

12 tests were completed in 289s with 12 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.endToEnd.TestHybrid 12✅ 289s

✅ com.linkedin.venice.endToEnd.TestHybrid

✅ testDuplicatedMessagesWontBePersisted[0](NO_OP)
✅ testDuplicatedMessagesWontBePersisted[2](GZIP)
✅ testDuplicatedMessagesWontBePersisted[4](ZSTD_WITH_DICT)
✅ testHybridDIVEnhancement
✅ testHybridMultipleVersions
✅ testHybridStoreLogCompaction
✅ testHybridWithPartitionWiseConsumer
✅ testHybridWithZeroLagThreshold
✅ testLeaderCanReleaseLatch
✅ testLeaderHonorLastTopicSwitchMessage
✅ testLeaderShouldCalculateRewindDuringPromotion
✅ testVersionSwapDeferredWithHybrid

✅ IntegrationTests_11-artifacts/internal/venice-test-common/build/test-results/integrationTests_11/TEST-com.linkedin.venice.helix.TestHelixReadOnlyStoreRepositoryAdapter.xml

8 tests were completed in 1s with 8 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.helix.TestHelixReadOnlyStoreRepositoryAdapter 8✅ 1s

✅ com.linkedin.venice.helix.TestHelixReadOnlyStoreRepositoryAdapter

✅ testGetAllStores
✅ testGetBatchGetLimit
✅ testGetStore
✅ testHasStore
✅ testIsReadComputationEnabled
✅ testListenersForVeniceStoreChange
✅ testListenersForVeniceStoreCreationDeletion
✅ testListenersForZKSharedStoreChange

✅ internal/venice-test-common/build/test-results/integrationTests_11/TEST-com.linkedin.venice.client.store.TestSslTransportClient.xml

2 tests were completed in 9s with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.client.store.TestSslTransportClient 2✅ 9s

✅ com.linkedin.venice.client.store.TestSslTransportClient

✅ testSslTransportClientCanTalkToRouter[0](master_controller)
✅ testSslTransportClientCanTalkToRouter[1](leader_controller)

✅ internal/venice-test-common/build/test-results/integrationTests_11/TEST-com.linkedin.venice.controller.server.TestAdminSparkServer.xml

39 tests were completed in 303s with 39 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.controller.server.TestAdminSparkServer 39✅ 303s

✅ com.linkedin.venice.controller.server.TestAdminSparkServer

✅ canCreateAHybridStore
✅ controllerCanGetDeletableStoreTopics
✅ controllerCanHandleLargePayload
✅ controllerClientCanCreateNewStore
✅ controllerClientCanDeleteAllVersion
✅ controllerClientCanDeleteOldVersion
✅ controllerClientCanDeleteStore
✅ controllerClientCanDisableStoresRead
✅ controllerClientCanDisableStoresReadWrite
✅ controllerClientCanDisableStoresWrite
✅ controllerClientCanDiscoverCluster
✅ controllerClientCanEnableMaxCapacityProtection
✅ controllerClientCanEnableThrottling
✅ controllerClientCanGetExecutionOfDeleteAllVersions
✅ controllerClientCanGetExecutionOfDeleteStore
✅ controllerClientCanGetLastSucceedExecutionId
✅ controllerClientCanGetStorageEngineOverheadRatio
✅ controllerClientCanGetStoreInfo
✅ controllerClientCanListFutureStoreVersions
✅ controllerClientCanListStoresStatuses
✅ controllerClientCanNotAutoMigrateStore
✅ controllerClientCanNotDeleteStore
✅ controllerClientCanQueryInstanceStatusInCluster
✅ controllerClientCanQueryNodesInCluster
✅ controllerClientCanQueryRemovability
✅ controllerClientCanQueryReplicasForTopic
✅ controllerClientCanQueryReplicasOnAStorageNode
✅ controllerClientCanSetStore
✅ controllerClientCanSetStoreMetadata
✅ controllerClientCanSetStoreMissingSomeFields
✅ controllerClientCanUpdateAllowList
✅ controllerClientGetKeySchema
✅ controllerClientManageValueSchema
✅ controllerClientProvidesErrorWhenRequestingTopicForStoreThatDoesNotExist
✅ controllerClientReturns404ForNonexistentStoreQuery
✅ controllerClientSchemaOperationsAgainstInvalidStore
✅ testAggregatedHealthStatusCall
✅ testCleanupInstanceCustomizedStates
✅ testDeleteKafkaTopic

✅ internal/venice-test-common/build/test-results/integrationTests_11/TEST-com.linkedin.venice.controller.TestDelayedRebalance.xml

5 tests were completed in 138s with 5 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.controller.TestDelayedRebalance 5✅ 138s

✅ com.linkedin.venice.controller.TestDelayedRebalance

✅ testDisableRebalanceTemporarily
✅ testEnableDelayedRebalance
✅ testFailOneServerWithDelayedRebalance
✅ testFailOneServerWithDelayedRebalanceTimeout
✅ testModifyDelayedRebalanceTime

✅ internal/venice-test-common/build/test-results/integrationTests_11/TEST-com.linkedin.venice.controller.VeniceParentHelixAdminTest.xml

8 tests were completed in 455s with 8 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.controller.VeniceParentHelixAdminTest 8✅ 455s

✅ com.linkedin.venice.controller.VeniceParentHelixAdminTest

✅ testAddVersion
✅ testHybridAndETLStoreConfig
✅ testResourceCleanupCheckForStoreRecreation
✅ testRollbackToBackupVersion
✅ testStoreMetaDataUpdateFromParentToChildController[0](true, true)
✅ testStoreMetaDataUpdateFromParentToChildController[2](false, false)
✅ testSupersetSchemaWithCustomSupersetSchemaGenerator
✅ testTerminalStateTopicChecker

✅ internal/venice-test-common/build/test-results/integrationTests_11/TEST-com.linkedin.venice.endToEnd.TestHybrid.xml

12 tests were completed in 289s with 12 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.endToEnd.TestHybrid 12✅ 289s

✅ com.linkedin.venice.endToEnd.TestHybrid

✅ testDuplicatedMessagesWontBePersisted[0](NO_OP)
✅ testDuplicatedMessagesWontBePersisted[2](GZIP)
✅ testDuplicatedMessagesWontBePersisted[4](ZSTD_WITH_DICT)
✅ testHybridDIVEnhancement
✅ testHybridMultipleVersions
✅ testHybridStoreLogCompaction
✅ testHybridWithPartitionWiseConsumer
✅ testHybridWithZeroLagThreshold
✅ testLeaderCanReleaseLatch
✅ testLeaderHonorLastTopicSwitchMessage
✅ testLeaderShouldCalculateRewindDuringPromotion
✅ testVersionSwapDeferredWithHybrid

✅ internal/venice-test-common/build/test-results/integrationTests_11/TEST-com.linkedin.venice.helix.TestHelixReadOnlyStoreRepositoryAdapter.xml

8 tests were completed in 1s with 8 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.helix.TestHelixReadOnlyStoreRepositoryAdapter 8✅ 1s

✅ com.linkedin.venice.helix.TestHelixReadOnlyStoreRepositoryAdapter

✅ testGetAllStores
✅ testGetBatchGetLimit
✅ testGetStore
✅ testHasStore
✅ testIsReadComputationEnabled
✅ testListenersForVeniceStoreChange
✅ testListenersForVeniceStoreCreationDeletion
✅ testListenersForZKSharedStoreChange