Skip to content

Address review comments #946

Address review comments

Address review comments #946

GitHub Actions / IntegrationTests_5 Test Reports succeeded Nov 22, 2025 in 0s

42 passed, 2 failed and 0 skipped

Tests failed

Report Passed Failed Skipped Time
IntegrationTests_5-artifacts/internal/venice-test-common/build/test-results/integrationTests_5/TEST-com.linkedin.venice.endToEnd.DaVinciClientRecordTransformerTest.xml 9✅ 1❌ 1390s
IntegrationTests_5-artifacts/internal/venice-test-common/build/test-results/integrationTests_5/TEST-com.linkedin.venice.endToEnd.DaVinciClientSubscribeTest.xml 11✅ 586s
IntegrationTests_5-artifacts/internal/venice-test-common/build/test-results/integrationTests_5/TEST-com.linkedin.venice.router.TestRouterAsyncStart.xml 1✅ 61s
internal/venice-test-common/build/test-results/integrationTests_5/TEST-com.linkedin.venice.endToEnd.DaVinciClientRecordTransformerTest.xml 9✅ 1❌ 1390s
internal/venice-test-common/build/test-results/integrationTests_5/TEST-com.linkedin.venice.endToEnd.DaVinciClientSubscribeTest.xml 11✅ 586s
internal/venice-test-common/build/test-results/integrationTests_5/TEST-com.linkedin.venice.router.TestRouterAsyncStart.xml 1✅ 61s

❌ IntegrationTests_5-artifacts/internal/venice-test-common/build/test-results/integrationTests_5/TEST-com.linkedin.venice.endToEnd.DaVinciClientRecordTransformerTest.xml

10 tests were completed in 1390s with 9 passed, 1 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.endToEnd.DaVinciClientRecordTransformerTest 9✅ 1❌ 1390s

❌ com.linkedin.venice.endToEnd.DaVinciClientRecordTransformerTest

✅ testRecordTransformer
✅ testBlobTransferRecordTransformer
✅ testRecordTransformerChunking
❌ testRecordTransformerDaVinciWithSeeking
	java.lang.AssertionError: expected [a3Transformed] but found [null]
✅ testRecordTransformerOnRecovery
✅ testRecordTransformerWithEmptyDaVinci
✅ testSkipResultRecordTransformer
✅ testTypeChangeRecordTransformer
✅ testUnchangedResultRecordTransformer
✅ testRecordTransformerDaVinciWithSeeking

✅ IntegrationTests_5-artifacts/internal/venice-test-common/build/test-results/integrationTests_5/TEST-com.linkedin.venice.endToEnd.DaVinciClientSubscribeTest.xml

11 tests were completed in 586s with 11 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.endToEnd.DaVinciClientSubscribeTest 11✅ 586s

✅ com.linkedin.venice.endToEnd.DaVinciClientSubscribeTest

✅ testBatchStore[0](DaVinciConfig{managed=true, isolated=false, storageClass=MEMORY_BACKED_BY_DISK, cacheConfig=null, largeBatchRequestSplitThreshold=100})
✅ testBatchStore[2](DaVinciConfig{managed=true, isolated=false, storageClass=MEMORY_BACKED_BY_DISK, cacheConfig=ObjectCacheConfig{maxCacheSize=Optional.empty, ttlInMilliseconds=Optional.empty}, largeBatchRequestSplitThreshold=100})
✅ testBootstrap[0](DaVinciConfig{managed=true, isolated=false, storageClass=MEMORY_BACKED_BY_DISK, cacheConfig=null, largeBatchRequestSplitThreshold=100})
✅ testBootstrap[2](DaVinciConfig{managed=true, isolated=false, storageClass=MEMORY_BACKED_BY_DISK, cacheConfig=ObjectCacheConfig{maxCacheSize=Optional.empty, ttlInMilliseconds=Optional.empty}, largeBatchRequestSplitThreshold=100})
✅ testBootstrapSubscription[0](DaVinciConfig{managed=true, isolated=false, storageClass=MEMORY_BACKED_BY_DISK, cacheConfig=null, largeBatchRequestSplitThreshold=100})
✅ testBootstrapSubscription[2](DaVinciConfig{managed=true, isolated=false, storageClass=MEMORY_BACKED_BY_DISK, cacheConfig=ObjectCacheConfig{maxCacheSize=Optional.empty, ttlInMilliseconds=Optional.empty}, largeBatchRequestSplitThreshold=100})
✅ testDavinciSubscribeFailureWithFullDisk
✅ testPartialSubscription[0](DaVinciConfig{managed=true, isolated=false, storageClass=MEMORY_BACKED_BY_DISK, cacheConfig=null, largeBatchRequestSplitThreshold=100})
✅ testPartialSubscription[2](DaVinciConfig{managed=true, isolated=false, storageClass=MEMORY_BACKED_BY_DISK, cacheConfig=ObjectCacheConfig{maxCacheSize=Optional.empty, ttlInMilliseconds=Optional.empty}, largeBatchRequestSplitThreshold=100})
✅ testSubscribeAndUnsubscribe
✅ testUnsubscribeBeforeFutureGet

✅ IntegrationTests_5-artifacts/internal/venice-test-common/build/test-results/integrationTests_5/TEST-com.linkedin.venice.router.TestRouterAsyncStart.xml

1 tests were completed in 61s with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.router.TestRouterAsyncStart 1✅ 61s

✅ com.linkedin.venice.router.TestRouterAsyncStart

✅ testConnectionWarmingFailureDuringSyncStart

❌ internal/venice-test-common/build/test-results/integrationTests_5/TEST-com.linkedin.venice.endToEnd.DaVinciClientRecordTransformerTest.xml

10 tests were completed in 1390s with 9 passed, 1 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.endToEnd.DaVinciClientRecordTransformerTest 9✅ 1❌ 1390s

❌ com.linkedin.venice.endToEnd.DaVinciClientRecordTransformerTest

✅ testRecordTransformer
✅ testBlobTransferRecordTransformer
✅ testRecordTransformerChunking
❌ testRecordTransformerDaVinciWithSeeking
	java.lang.AssertionError: expected [a3Transformed] but found [null]
✅ testRecordTransformerOnRecovery
✅ testRecordTransformerWithEmptyDaVinci
✅ testSkipResultRecordTransformer
✅ testTypeChangeRecordTransformer
✅ testUnchangedResultRecordTransformer
✅ testRecordTransformerDaVinciWithSeeking

✅ internal/venice-test-common/build/test-results/integrationTests_5/TEST-com.linkedin.venice.endToEnd.DaVinciClientSubscribeTest.xml

11 tests were completed in 586s with 11 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.endToEnd.DaVinciClientSubscribeTest 11✅ 586s

✅ com.linkedin.venice.endToEnd.DaVinciClientSubscribeTest

✅ testBatchStore[0](DaVinciConfig{managed=true, isolated=false, storageClass=MEMORY_BACKED_BY_DISK, cacheConfig=null, largeBatchRequestSplitThreshold=100})
✅ testBatchStore[2](DaVinciConfig{managed=true, isolated=false, storageClass=MEMORY_BACKED_BY_DISK, cacheConfig=ObjectCacheConfig{maxCacheSize=Optional.empty, ttlInMilliseconds=Optional.empty}, largeBatchRequestSplitThreshold=100})
✅ testBootstrap[0](DaVinciConfig{managed=true, isolated=false, storageClass=MEMORY_BACKED_BY_DISK, cacheConfig=null, largeBatchRequestSplitThreshold=100})
✅ testBootstrap[2](DaVinciConfig{managed=true, isolated=false, storageClass=MEMORY_BACKED_BY_DISK, cacheConfig=ObjectCacheConfig{maxCacheSize=Optional.empty, ttlInMilliseconds=Optional.empty}, largeBatchRequestSplitThreshold=100})
✅ testBootstrapSubscription[0](DaVinciConfig{managed=true, isolated=false, storageClass=MEMORY_BACKED_BY_DISK, cacheConfig=null, largeBatchRequestSplitThreshold=100})
✅ testBootstrapSubscription[2](DaVinciConfig{managed=true, isolated=false, storageClass=MEMORY_BACKED_BY_DISK, cacheConfig=ObjectCacheConfig{maxCacheSize=Optional.empty, ttlInMilliseconds=Optional.empty}, largeBatchRequestSplitThreshold=100})
✅ testDavinciSubscribeFailureWithFullDisk
✅ testPartialSubscription[0](DaVinciConfig{managed=true, isolated=false, storageClass=MEMORY_BACKED_BY_DISK, cacheConfig=null, largeBatchRequestSplitThreshold=100})
✅ testPartialSubscription[2](DaVinciConfig{managed=true, isolated=false, storageClass=MEMORY_BACKED_BY_DISK, cacheConfig=ObjectCacheConfig{maxCacheSize=Optional.empty, ttlInMilliseconds=Optional.empty}, largeBatchRequestSplitThreshold=100})
✅ testSubscribeAndUnsubscribe
✅ testUnsubscribeBeforeFutureGet

✅ internal/venice-test-common/build/test-results/integrationTests_5/TEST-com.linkedin.venice.router.TestRouterAsyncStart.xml

1 tests were completed in 61s with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
com.linkedin.venice.router.TestRouterAsyncStart 1✅ 61s

✅ com.linkedin.venice.router.TestRouterAsyncStart

✅ testConnectionWarmingFailureDuringSyncStart

Annotations

Check failure on line 941 in internal/venice-test-common/src/integrationTest/java/com/linkedin/venice/endToEnd/DaVinciClientRecordTransformerTest.java

See this annotation in the file changed.

@github-actions github-actions / IntegrationTests_5 Test Reports

com.linkedin.venice.endToEnd.DaVinciClientRecordTransformerTest ► testRecordTransformerDaVinciWithSeeking

Failed test found in:
  IntegrationTests_5-artifacts/internal/venice-test-common/build/test-results/integrationTests_5/TEST-com.linkedin.venice.endToEnd.DaVinciClientRecordTransformerTest.xml
  internal/venice-test-common/build/test-results/integrationTests_5/TEST-com.linkedin.venice.endToEnd.DaVinciClientRecordTransformerTest.xml
Error:
  java.lang.AssertionError: expected [a3Transformed] but found [null]
Raw output
java.lang.AssertionError: expected [a3Transformed] but found [null]
	at org.testng.Assert.fail(Assert.java:96)
	at org.testng.Assert.failNotEquals(Assert.java:776)
	at org.testng.Assert.assertEqualsImpl(Assert.java:132)
	at org.testng.Assert.assertEquals(Assert.java:118)
	at org.testng.Assert.assertEquals(Assert.java:453)
	at org.testng.Assert.assertEquals(Assert.java:463)
	at com.linkedin.venice.endToEnd.DaVinciClientRecordTransformerTest.lambda$testRecordTransformerDaVinciWithSeeking$11(DaVinciClientRecordTransformerTest.java:941)
	at com.linkedin.venice.utils.TestUtils.waitForNonDeterministicAssertion(TestUtils.java:287)
	at com.linkedin.venice.utils.TestUtils.waitForNonDeterministicAssertion(TestUtils.java:272)
	at com.linkedin.venice.utils.TestUtils.waitForNonDeterministicAssertion(TestUtils.java:264)
	at com.linkedin.venice.endToEnd.DaVinciClientRecordTransformerTest.testRecordTransformerDaVinciWithSeeking(DaVinciClientRecordTransformerTest.java:935)