enable multi-key modifier with floating_modifier (revised)#9137
Open
carpetoctopus wants to merge 3 commits into
Open
enable multi-key modifier with floating_modifier (revised)#9137carpetoctopus wants to merge 3 commits into
carpetoctopus wants to merge 3 commits into
Conversation
…e floating_modifier command. Using mostly the same code as sway/commands/bar/modifier.c to modify sway/commands/floating_modifier.c. sway/input/cursor.c and sway/input/seatop_default.c are changed to check if all floating modifier keys are pressed, instead of just one.
…e floating_modifier command. Using mostly the same code as sway/commands/bar/modifier.c to modify sway/commands/floating_modifier.c. sway/input/cursor.c and sway/input/seatop_default.c are changed to check if all floating modifier keys are pressed, instead of just one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit allows multiple modifier keys to be used in combination for floating_modifier.
Example:
floating_modifier Shift+Alt normal
will work, whereas before it would throw an "Invalid modifier" error.
If the key combination contains multiple keys and not all of them are pressed, the drag/resize will not happen. If one of the keys is not a valid modifier key, an error will be thrown.