PackagePIFProjectBuilder+Modules.swift: Add missing .emscripten#10002
Open
MaxDesiatov wants to merge 5 commits into
Open
PackagePIFProjectBuilder+Modules.swift: Add missing .emscripten#10002MaxDesiatov wants to merge 5 commits into
.emscripten#10002MaxDesiatov wants to merge 5 commits into
Conversation
Contributor
MaxDesiatov
commented
Apr 29, 2026
MaxDesiatov
commented
MaxDesiatov
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveinglis,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand and
rconnell9
as code owners
Contributor
Author
|
@swift-ci test |
artemcm
approved these changes
Apr 29, 2026
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
Contributor
Author
|
@swift-ci test windows self-hosted |
bkhouri
reviewed
Apr 29, 2026
bkhouri
approved these changes
Apr 29, 2026
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
Contributor
Author
|
@swift-ci test macos |
owenv
requested changes
Apr 29, 2026
Contributor
owenv
left a comment
owenv
left a comment
There was a problem hiding this comment.
Renaming the webassembly platform to was requires additional coordinated changes that are breaking the integration tests here. Reverting in swiftlang/swift-build#1358 for now
owenv
approved these changes
Apr 30, 2026
Contributor
owenv
left a comment
owenv
left a comment
There was a problem hiding this comment.
I believe this is correct now, thanks
| configDir += "-android" | ||
| } else if self.triple.isWasm { | ||
| } else if self.triple.isWasm && self.triple.isNoneOS() { | ||
| // Legacy suffix for bare-metal wasm (wasm32-unknown-none-wasm). |
Contributor
There was a problem hiding this comment.
Why do we need this? This has never been a thing until Swift Build, which isn't even released yet.
```
14:09:47 /Users/ec2-user/jenkins/workspace/swift-package-manager-with-xcode-self-hosted-PR-osx-release-toolchain/branch-main/swiftpm/Sources/SwiftBuildSupport/PackagePIFProjectBuilder+Modules.swift:569:17: error: switch must be exhaustive
14:09:47 567 | for platform in ProjectModel.BuildSettings.Platform.allCases {
14:09:47 568 | // darwin & freebsd
14:09:47 569 | switch platform {
14:09:47 | |- error: switch must be exhaustive
14:09:47 | `- note: add missing case: '.emscripten'
14:09:47 570 | case .macOS, .macCatalyst, .iOS, .watchOS, .tvOS, .xrOS, .driverKit, .freebsd:
14:09:47 571 | impartedSettings[.OTHER_LDFLAGS, platform] = ["-lc++", "$(inherited)"]
```
MaxDesiatov
force-pushed
the
maxd/emscripten-fix
branch
from
58ab687 to
5f7ab0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.