Diagnose *all* cases where a subclass fails to override a required init #70236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where a subclass was unable to synthesize any initializers (for example, because there were missing designated initializers in the superclass), we were skipping checking of superclass required initializers. This meant that we would silently accept subclasses that cannot be initialized directly (that would produce an error), but could at runtime be initialized via a required initializer... that didn't account for the subclass. Fixes the original problem from swiftlang#69965, but not the most minimal one.
DougGregor
requested review from
AnthonyLatsis,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
|
Linux failure is "No space left on device" |
|
@swift-ci please clean smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where a subclass was unable to synthesize any initializers (for example, because there were missing designated initializers in the superclass), we were skipping checking of superclass required initializers. This meant that we would silently accept subclasses that cannot be initialized directly (that would produce an error), but could at runtime be initialized via a required initializer... that didn't account for the subclass.
Fixes the original problem from #69965.