[gardening]: update macos architecture wording in README build state matrix #81276
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…matrix the current macos CI builds for both x86 and arm, but the README suggested that it was only x86. update the terminology to make things a bit more clear.
jamieQ
commented
May 3, 2025
| @@ -8,7 +8,7 @@ | |||
|
|
|||
| | | **Architecture** | **Build** | | |||
| |---|:---:|:---:| | |||
| | **macOS** | x86_64 |[](https://ci.swift.org/job/oss-swift-package-macos)| | |||
| | **macOS** | Universal |[](https://ci.swift.org/job/oss-swift-package-macos)| | |||
There was a problem hiding this comment.
happy to change if alternate wording would be more appropriate
There was a problem hiding this comment.
Does it actually run the tests for arm64 too? The point of these CI badges is that the tests are run...
There was a problem hiding this comment.
that is a good point, and i'm not sure – perhaps one of the reviewers can speak to this. looking at the output of the 'build script analyzer' in the CI logs i see :
03:32:46 --- Build Script Analyzer ---
03:32:46 Build Script Log: /Users/ec2-user/jenkins/workspace/oss-swift-package-macos/build/.build_script_log
03:32:46 Build Percentage Build Duration (sec) Build Phase
03:32:46 ================ ==================== ===========
03:32:46 37.9% 12858.55 macosx-x86_64-swift-test
03:32:46 12.0% 4089.18 macosx-x86_64-swift-build
...
03:32:46 3.9% 1310.03 macosx-arm64-swift-build
...so it looks like x86 is tested, but i see no analogous 'macosx-arm64-swift-test' entry, which is curious. i agree that if arm tests aren't run this change could be misleading, so perhaps shouldn't be made.
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the current macos CI builds for both x86 and arm, but the README suggested that it was only x86. update the terminology to make things a bit more clear.
relevant forum post: https://forums.swift.org/t/how-to-add-a-ci-badge-for-macos-aarch64-builds/79622