Skip to content

[gardening]: update macos architecture wording in README build state matrix #81276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged

[gardening]: update macos architecture wording in README build state matrix #81276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

| | **Architecture** | **Build** |
|---|:---:|:---:|
| **macOS** | x86_64 |[![Build Status](https://ci.swift.org/job/oss-swift-package-macos/lastCompletedBuild/badge/icon)](https://ci.swift.org/job/oss-swift-package-macos)|
| **macOS** | Universal |[![Build Status](https://ci.swift.org/job/oss-swift-package-macos/lastCompletedBuild/badge/icon)](https://ci.swift.org/job/oss-swift-package-macos)|
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy to change if alternate wording would be more appropriate

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it actually run the tests for arm64 too? The point of these CI badges is that the tests are run...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is a good point, and i'm not sure – perhaps one of the reviewers can speak to this. looking at the output of the 'build script analyzer' in the CI logs i see :

03:32:46  --- Build Script Analyzer ---
03:32:46  Build Script Log: /Users/ec2-user/jenkins/workspace/oss-swift-package-macos/build/.build_script_log
03:32:46  Build Percentage 	 Build Duration (sec) 	 Build Phase
03:32:46  ================ 	 ==================== 	 ===========
03:32:46  37.9%             	 12858.55              	 macosx-x86_64-swift-test
03:32:46  12.0%             	 4089.18               	 macosx-x86_64-swift-build
...
03:32:46  3.9%              	 1310.03               	 macosx-arm64-swift-build
...

so it looks like x86 is tested, but i see no analogous 'macosx-arm64-swift-test' entry, which is curious. i agree that if arm tests aren't run this change could be misleading, so perhaps shouldn't be made.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahmishal i see you merged this already, but can you (or someone) please address the question raised here when you have a moment? i.e. does this CI job also run tests for macos-arm64 builds?

| **Ubuntu 20.04** | x86_64 |[![Build Status](https://ci.swift.org/job/oss-swift-package-ubuntu-20_04/lastCompletedBuild/badge/icon)](https://ci.swift.org/job/oss-swift-package-ubuntu-20_04)|
| **Ubuntu 20.04** | AArch64 |[![Build Status](https://ci.swift.org/job/oss-swift-package-ubuntu-20_04-aarch64/lastCompletedBuild/badge/icon)](https://ci.swift.org/job/oss-swift-package-ubuntu-20_04-aarch64)|
| **Ubuntu 22.04** | x86_64 |[![Build Status](https://ci.swift.org/job/oss-swift-package-ubuntu-22_04/lastCompletedBuild/badge/icon)](https://ci.swift.org/job/oss-swift-package-ubuntu-22_04)|
Expand Down