feat: don't add substates that are already being processed #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cifko
force-pushed
the
disallow-same-substate-tx
branch
from
4273860 to
2065be3
Compare
sdbondi
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
utACK
Ah I didn't initially think this was happening on the database layer, we should definitely write some docs on the expected behaviour of each method in the storage interface (#890). We may encounter other issues but this should fix the specific issue with incorrect proposals.
Merged
via the queue into
tari-project:development
with commit Jan 12, 2024
63a1563
10 checks passed
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
…ls (#894) Description --- Includes locks in evidence Checks locks when proposing to allow multiple input refs Motivation and Context --- Evidence for each shard within a TransactionAtom now includes the lock type. Updated the proposal db query to check each lock type and ensure that conflicts either don't occur or if they do they are all read locks. How Has This Been Tested? --- Ran a stress test from #880, previously after #885 was merged, funding the tariswap components would take a very long time (I've never actually run it to completion, but ran for 30 mins without completing). With this PR funding took roughly a minute on my test. Swap batches are also reaching finalization within an acceptable timeframe. What process can a PR reviewer use to test or verify this change? --- Submit multiple transactions which use a single substate as an input ref and check that they can be added to the same block. Breaking Changes --- - [ ] None - [x] Requires data directory to be deleted (Evidence struct changed) - [ ] Other - Please specify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't add transaction to a proposal if any of their substates is being processed.
Motivation and Context
I left one TODO in the code. Because if we don't switch to the "no version" transaction, them we can add aborts directly to the proposal.
How Has This Been Tested?
I tried 9 concurrent transaction 9 accounts to 1, and 1 accounts to 9.
What process can a PR reviewer use to test or verify this change?
Breaking Changes