feat: remove serde-byte-array #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
approved these changes
Jan 19, 2024
sdbondi
approved these changes
Jan 22, 2024
Merged
via the queue into
tari-project:development
with commit Jan 22, 2024
f85608a
11 checks passed
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Jan 22, 2024
* development: feat: remove serde-byte-array (tari-project#909) fix: ui (tari-project#907) fix: uncomment sync cucumber test (tari-project#905)
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Jan 22, 2024
* development: feat: remove serde-byte-array (tari-project#909) fix: ui (tari-project#907)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
serde-byte-arraycrate, useserde_as(as = "Bytes")(available inserde_withcrate, that we are already using) instead where necessary. Also add this serialization toHash. This fixes the variable fees for transaction which was caused by the default CBOR serialization of arrays.Before this change the fees for transactions were:
account create 371-375
transaction(non confidential) 736-742
After this change.
account create 355
transaction(non confidential) 701
Motivation and Context
How Has This Been Tested?
Running dan-testing with 2 committees and 10 accounts and transactions in between.
What process can a PR reviewer use to test or verify this change?
Probably something similar as above.
Breaking Changes