use maxlength instead #2562
Closed
use maxlength instead #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GraceGardner
requested review from
GiantRobots
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Let's check out the ticket again, it's talking about a Search Attribute with Int type not the Workflow Type field which is a string. |
Alex-Tideman
requested changes
Feb 19, 2025
laurakwhit
reviewed
Feb 19, 2025
| @@ -216,6 +216,7 @@ | |||
| bind:value={workflowId} | |||
| label="Workflow ID" | |||
| class="w-full grow" | |||
| maxLength={36} | |||
There was a problem hiding this comment.
Just noting that whatever we do here we'll likely also need to do for the Workflow ID input in the schedule form.
There was a problem hiding this comment.
Actually, looking at the original issue here and I think it lies with the custom search attribute input not with the inputs on these forms.
There was a problem hiding this comment.
^ Yup this is for the Int type input for a Search Attribute
There was a problem hiding this comment.
Thank you both!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Add maxlength to workflowid. I went with 36 as the max length because that's what I guess is UUID standard. Original ticket was suggesting a max for an INT, but it looks like since then we changed from an int to a UUID.
Testing 🧪
Go to start a work flow, try to put in an id longer than 36 characters. It now maxes out at 36 and does not allow the user to put in a larger input.
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Go to start a work flow, try to put in an id longer than 36 characters. It now maxes out at 36 and does not allow the user to put in a larger input.
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
DT-2701
Docs
Any docs updates needed?