Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use maxlength instead #2562

Closed
wants to merge 2 commits into from
Closed

use maxlength instead #2562

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8febe9c
use maxlength instead
GraceGardner Feb 19, 2025
3fe2bed
cap L
GraceGardner Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/lib/pages/start-workflow.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@
bind:value={workflowId}
label="Workflow ID"
class="w-full grow"
maxLength={36}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that whatever we do here we'll likely also need to do for the Workflow ID input in the schedule form.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, looking at the original issue here and I think it lies with the custom search attribute input not with the inputs on these forms.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ Yup this is for the Int type input for a Search Attribute

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both!

on:blur={(e) => onInputChange(e, 'workflowId')}
/>
<Button
Expand Down
Loading