fix/remove imports from svelte/internal #2569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossedfort
requested review from
stevekinney,
Alex-Tideman and
a team
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
GiantRobots
reviewed
Feb 20, 2025
| @@ -46,7 +45,7 @@ | |||
| export let expandAll = false; | |||
| export let typedError = false; | |||
| export let active = false; | |||
| export let onRowClick: () => void = noop; | |||
| export let onRowClick: () => void = () => {}; | |||
There was a problem hiding this comment.
These look goo to me but this function could also be () => void no need to change just commenting.
There was a problem hiding this comment.
I thought void was only valid as a type declaration, not the function itself 🤔
GiantRobots
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
As of Svelte 5, svelte/internal has been removed
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?