-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused parameters related to reactivity coefficients #1501
Conversation
@john-science We should talk about this in person tomorrow, if you have some time. |
Chris and I have reviewed this. This PR is tacitly approved, based on some testing Chris is running. But also, I'm not going to hit "Approve" here until after the testing is complete (~24 hours), because I don't want someone YOLO-merging this PR just yet. |
@john-science My internal testing came back clean. This consisted of running our integration tests and also a benchmark case that exercises this part of the code. |
Test coverage only went down because we removed lines of code. That is exceptable. |
Thanks @john-science . I can coordinate the merge, since there are a few internal repos that will be merged simultaneously. |
…ower/armi into removeUnusedRxcoeffParams
It was pointed out to me by @mgjarrett that I shouldn't remove |
What is the change?
This PR is a big housecleaning of a bunch of parameters that were related to our old internal implementation of reactivity coefficient calculations. They are not used anywhere. I have run our internal integration tests and found no issues.
Why is the change being made?
These parameters are unused bloat. They should have been removed a long time ago. Many of them are ambiguous. Having these around makes working with parameters programmatically difficult.
Side note: These parameters would more properly belong in a plugin, since they are very specific and not used by multiple plugins.
Checklist
doc/release/0.X.rst
) are up-to-date with any important changes.doc
folder.pyproject.toml
.