Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused parameters related to reactivity coefficients #1501

Merged
merged 6 commits into from
Dec 1, 2023
Merged

Remove unused parameters related to reactivity coefficients #1501

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b6ba948
Remove block and assembly parameters which are unused
keckler Nov 27, 2023
be0aeab
Remove unused core parameters
keckler Nov 28, 2023
87b11e0
Update changelog
keckler Nov 28, 2023
ce164c9
Merge branch 'main' into removeUnusedRxcoeffParams
keckler Nov 28, 2023
a00217f
Put back rxFuelAxialExpansionPerPercent
keckler Nov 30, 2023
d287bc9
Merge branch 'removeUnusedRxcoeffParams' of https://github.com/terrap…
keckler Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 0 additions & 42 deletions armi/reactor/assemblyParameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,40 +319,12 @@ def _enforceNotesRestrictions(self, value):

pb.defParam("assemNum", units=units.UNITLESS, description="Assembly number")

pb.defParam(
"axExpWorthPT",
units=f"{units.PCM}/{units.PERCENT}/{units.CM}^3",
description="Axial swelling reactivity",
location=ParamLocation.AVERAGE,
)

pb.defParam(
"coolFlowingWorthPT",
units=f"{units.PCM}/{units.PERCENT}/{units.CM}^3",
description="Flowing coolant reactivity",
location=ParamLocation.AVERAGE,
)

pb.defParam(
"coolWorthPT",
units=f"{units.PCM}/{units.PERCENT}/{units.CM}^3",
description="Coolant reactivity",
location=ParamLocation.AVERAGE,
)

pb.defParam(
"dischargeTime",
units=units.YEARS,
description="Time the Assembly was removed from the Reactor.",
)

pb.defParam(
"fuelWorthPT",
units=f"{units.PCM}/{units.PERCENT}/{units.CM}^3",
description="Fuel reactivity",
location=ParamLocation.AVERAGE,
)

pb.defParam(
"hotChannelFactors",
units=units.UNITLESS,
Expand All @@ -362,20 +334,6 @@ def _enforceNotesRestrictions(self, value):
categories=[parameters.Category.assignInBlueprints],
)

pb.defParam(
"radExpWorthPT",
units=f"{units.PCM}/{units.PERCENT}/{units.CM}^3",
description="Radial swelling reactivity",
location=ParamLocation.AVERAGE,
)

pb.defParam(
"structWorthPT",
units=f"{units.PCM}/{units.PERCENT}/{units.CM}^3",
description="Structure reactivity",
location=ParamLocation.AVERAGE,
)

with pDefs.createBuilder(categories=["radialGeometry"]) as pb:

pb.defParam(
Expand Down
209 changes: 0 additions & 209 deletions armi/reactor/blockParameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,187 +429,6 @@ def xsTypeNum(self, value):
saveToDB=True,
)

with pDefs.createBuilder(
default=0.0,
location=ParamLocation.AVERAGE,
categories=["reactivity coefficients"],
) as pb:

pb.defParam(
"VoideddopplerWorth",
units=f"{units.REACTIVITY}*{units.DEGK}^(n-1)",
description="Distributed Voided Doppler constant.",
)

pb.defParam(
"dopplerWorth",
units=f"{units.REACTIVITY}*{units.DEGK}^(n-1)",
description="Distributed Doppler constant.",
)

pb.defParam(
"fuelWorth",
units=f"{units.REACTIVITY}/{units.KG}",
description="Reactivity worth of fuel material per unit mass",
)

pb.defParam(
"fuelWorthPT",
units=f"{units.PCM}/{units.PERCENT}/{units.CM}^3",
description="Fuel reactivity",
)

pb.defParam(
"structWorthPT",
units=f"{units.PCM}/{units.PERCENT}/{units.CM}^3",
description="Structure reactivity",
)

pb.defParam(
"radExpWorthPT",
units=f"{units.PCM}/{units.PERCENT}/{units.CM}^3",
description="Radial swelling reactivity",
)

pb.defParam(
"coolWorthPT",
units=f"{units.PCM}/{units.PERCENT}/{units.CM}^3",
description="Coolant reactivity",
)

pb.defParam(
"coolFlowingWorthPT",
units=f"{units.PCM}/{units.PERCENT}/{units.CM}^3",
description="Flowing coolant reactivity",
)

pb.defParam(
"axExpWorthPT",
units=f"{units.PCM}/{units.PERCENT}/{units.CM}^3",
description="Axial swelling reactivity",
)

pb.defParam(
"coolantWorth",
units=f"{units.REACTIVITY}/{units.KG}",
description="Reactivity worth of coolant material per unit mass",
)

pb.defParam(
"cladWorth",
units=f"{units.REACTIVITY}/{units.KG}",
description="Reactivity worth of clad material per unit mass",
)

pb.defParam(
"rxAxialCentsPerK",
units=f"{units.CENTS}/{units.DEGK}",
description="Axial temperature reactivity coefficient",
)

pb.defParam(
"rxAxialCentsPerPow",
units=f"{units.CENTS}/{units.DEGK}",
description="Axial power reactivity coefficient",
)

pb.defParam(
"rxCoolantCentsPerK",
units=f"{units.CENTS}/{units.DEGK}",
description="Coolant temperature reactivity coefficient",
)

pb.defParam(
"rxCoolantCentsPerPow",
units=f"{units.CENTS}/{units.DEGK}",
description="Coolant power reactivity coefficient",
)

pb.defParam(
"rxDopplerCentsPerK",
units=f"{units.CENTS}/{units.DEGK}",
description="Doppler temperature reactivity coefficient",
)

pb.defParam(
"rxDopplerCentsPerPow",
units=f"{units.CENTS}/{units.DEGK}",
description="Doppler power reactivity coefficient",
)

pb.defParam(
"rxFuelCentsPerK",
units=f"{units.CENTS}/{units.DEGK}",
description="Fuel temperature reactivity coefficient",
)

pb.defParam(
"rxFuelCentsPerPow",
units=f"{units.CENTS}/{units.DEGK}",
description="Fuel power reactivity coefficient",
)

pb.defParam(
"rxNetCentsPerK",
units=f"{units.CENTS}/{units.DEGK}",
description="Net temperature reactivity coefficient",
)

pb.defParam(
"rxNetCentsPerPow",
units=f"{units.CENTS}/{units.DEGK}",
description="Net power reactivity coefficient",
location=ParamLocation.AVERAGE,
)

pb.defParam(
"rxNetPosNeg",
units=f"{units.CENTS}/{units.DEGK}",
description="Net temperature reactivity coefficient: positive or negative",
)

pb.defParam(
"rxNetPosNegPow",
units=f"{units.CENTS}/{units.DEGK}",
description="Net power reactivity coefficient: positive or negative",
)

pb.defParam(
"rxRadialCentsPerK",
units=f"{units.CENTS}/{units.DEGK}",
description="Radial temperature reactivity coefficient",
)

pb.defParam(
"rxRadialCentsPerPow",
units=f"{units.CENTS}/{units.DEGK}",
description="Radial power reactivity coefficient",
)

pb.defParam(
"rxStructCentsPerK",
units=f"{units.CENTS}/{units.DEGK}",
description="Structure temperature reactivity coefficient",
)

pb.defParam(
"rxStructCentsPerPow",
units=f"{units.CENTS}/{units.DEGK}",
description="Structure power reactivity coefficient",
)

pb.defParam(
"rxVoidedDopplerCentsPerK",
units=f"{units.CENTS}/{units.DEGK}",
description="Voided Doppler temperature reactivity coefficient",
)

pb.defParam(
"rxVoidedDopplerCentsPerPow",
units=f"{units.CENTS}/{units.DEGK}",
description="Voided Doppler power reactivity coefficient",
)

with pDefs.createBuilder(
default=0.0,
location=ParamLocation.AVERAGE,
Expand Down Expand Up @@ -883,13 +702,6 @@ def xsTypeNum(self, value):
location=ParamLocation.AVERAGE,
)

pb.defParam(
"coolRemFrac",
units=units.UNITLESS,
description="Fractional sodium density change for each block",
location=ParamLocation.AVERAGE,
)

pb.defParam(
"crWastage",
units=units.MICRONS,
Expand All @@ -904,27 +716,6 @@ def xsTypeNum(self, value):
location=ParamLocation.AVERAGE,
)

pb.defParam(
"deltaTclad",
units=f"{units.DEGK}/{units.PERCENT}",
description=r"Change in fuel temperature due to 1% rise in power.",
location=ParamLocation.AVERAGE,
)

pb.defParam(
"deltaTduct",
units=f"{units.DEGK}/{units.PERCENT}",
description=r"Change in fuel temperature due to 1% rise in power.",
location=ParamLocation.AVERAGE,
)

pb.defParam(
"deltaTfuel",
units=f"{units.DEGK}/{units.PERCENT}",
description=r"Change in fuel temperature due to 1% rise in power.",
location=ParamLocation.AVERAGE,
)

pb.defParam(
"heightBOL",
units=units.CM,
Expand Down
78 changes: 0 additions & 78 deletions armi/reactor/reactorParameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,78 +521,6 @@ def defineCoreParameters():
),
)

with pDefs.createBuilder(
default=0.0,
location=ParamLocation.AVERAGE,
categories=["reactivity coefficients"],
) as pb:

pb.defParam(
"axial",
units=f"{units.CENTS}/{units.DEGK}",
description="Axial expansion coefficient",
)

pb.defParam(
"doppler",
units=f"{units.CENTS}/{units.DEGK}",
description="Doppler coefficient",
)

pb.defParam(
"dopplerConst",
units=f"{units.CENTS}*{units.DEGK}^(n-1)",
description="Doppler constant",
)

pb.defParam(
"fuelDensity",
units=f"{units.CENTS}/{units.DEGK}",
description="Fuel temperature coefficient",
)

pb.defParam(
"coolantDensity",
units=f"{units.CENTS}/{units.DEGK}",
description="Coolant temperature coefficient",
)

pb.defParam(
"totalCoolantDensity",
units=f"{units.CENTS}/{units.DEGK}",
description="Coolant temperature coefficient weighted to include bond and interstitial effects",
)

pb.defParam(
"Voideddoppler",
units=f"{units.CENTS}/{units.DEGK}",
description="Voided Doppler coefficient",
)

pb.defParam(
"VoideddopplerConst",
units=f"{units.CENTS}*{units.DEGK}^(n-1)",
description="Voided Doppler constant",
)

pb.defParam(
"voidWorth", units=f"{units.DOLLARS}", description="Coolant void worth"
)

pb.defParam("voidedKeff", units=units.UNITLESS, description="Voided keff")

pb.defParam(
"radialHT9",
units=f"{units.CENTS}/{units.DEGK}",
description="Radial expansion coefficient when driven by thermal expansion of HT9.",
)

pb.defParam(
"radialSS316",
units=f"{units.CENTS}/{units.DEGK}",
description="Radial expansion coefficient when driven by thermal expansion of SS316.",
)

with pDefs.createBuilder(
default=0.0,
location=ParamLocation.AVERAGE,
Expand Down Expand Up @@ -644,12 +572,6 @@ def defineCoreParameters():
description="Fuel Axial Expansion Coefficient",
)

pb.defParam(
"rxFuelAxialExpansionCoeffPerPercent",
units="dk/kk'-%",
description="Fuel Axial Expansion Coefficient",
)

pb.defParam(
"rxGridPlateRadialExpansionCoeffPerTemp",
units=f"{units.REACTIVITY}/{units.DEGK}",
Expand Down
2 changes: 0 additions & 2 deletions armi/utils/reportPlotting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,8 +451,6 @@ def _getNeutronicVals(r):
("Rx. Swing", r.core.p.rxSwing),
("Fast Flux Fr.", r.core.p.fastFluxFrAvg),
("Leakage", r.core.p.leakageFracTotal),
("Void worth", r.core.p.voidWorth),
("Doppler", r.core.p.doppler),
("Beta", r.core.p.beta),
("Peak flux", r.core.p.maxFlux),
]
Expand Down
Loading
Loading