-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding impl/test crumbs for requirements #1507
Conversation
.. impl:: Any depletable component will be adjusted. | ||
:id: I_ARMI_BP_NUC_FLAGS | ||
:implements: R_ARMI_BP_NUC_FLAGS | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is in the most appropriate place? I would assume this would be better put into somewhere in isotopicOptions
, but let me know if I'm misunderstanding your intent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, or maybe this is just one part of it. I guess the user needs to define composite objects with the DEPLETABLE
flag, which would happen in other parts of the blueprints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a "blueprint requirement", so I put it in the most general place in the blueprints.
That's really as far as my thought process went.
Hmmm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, well it is good where it is, by the logic of my second comment above. But during the upcoming "real" review, I anticipate we'll probably ask for another impl in the isotopicOptions
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. Take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the additions!
What is the change?
Adding impl/test crumbs for assorted requirements.
Why is the change being made?
This is part of on-going requirements work.
Checklist
doc/release/0.X.rst
) are up-to-date with any important changes.doc
folder.pyproject.toml
.