fix: calculate changes for input properties like component properties #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
| setComponentInputs(fixture, newComponentInputs); | ||
| const changesInComponentInput = update(fixture, renderedInputKeys, newComponentInputs, setComponentInputs); | ||
| renderedInputKeys = Object.keys(newComponentInputs); | ||
|
|
||
| const newComponentOutputs = properties?.componentOutputs ?? {}; |
There was a problem hiding this comment.
[JFI] On a quick local test, changes in component outputs are not included in ngOnChanges. So I think we only need to calculate changes from component inputs and component properties.
There was a problem hiding this comment.
Sounds good to me!
Thanks a lot for this, I was just going to take a stab at it but you beat me to it 👍
timdeschryver
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #365