-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update authors information #717
Conversation
"email": "[email protected]", | ||
"url": "https://regadas.dev" | ||
"name": "Trino Javascript contributors", | ||
"email": "[email protected]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you might know, how about to use the contributors field?
https://docs.npmjs.com/cli/v10/configuring-npm/package-json#people-fields-author-contributors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure .. but that would mean we have to maintain each person in the package.jon file in addition. We want to avoid that with this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get a small amount of emails, mainly asking for help.
"url": "https://regadas.dev" | ||
"name": "Trino Javascript contributors", | ||
"email": "[email protected]", | ||
"url": "https://github.com/trinodb/trino-js-client/graphs/contributors" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do a similar thing in the airbase pom and that is inherited into Trino .. so this would be a consistent approach with it for JavaScript
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this approach
@mosabua since we gonna do a release soon do you want to move forward with this and change later if it's not ok? let me know how to proceed |
Yeah .. lets go. |
No description provided.