Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update authors information #717

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Update authors information #717

merged 1 commit into from
Nov 18, 2024

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Nov 13, 2024

No description provided.

@mosabua mosabua requested a review from regadas November 13, 2024 18:22
@cla-bot cla-bot bot added the cla-signed label Nov 13, 2024
"email": "[email protected]",
"url": "https://regadas.dev"
"name": "Trino Javascript contributors",
"email": "[email protected]",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how much emails you used to get via this @regadas .. and also .. this new email is monitored by @martint .. how do we want to handle this in terms of forwarding or whatever

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you might know, how about to use the contributors field?
https://docs.npmjs.com/cli/v10/configuring-npm/package-json#people-fields-author-contributors

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure .. but that would mean we have to maintain each person in the package.jon file in addition. We want to avoid that with this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get a small amount of emails, mainly asking for help.

"url": "https://regadas.dev"
"name": "Trino Javascript contributors",
"email": "[email protected]",
"url": "https://github.com/trinodb/trino-js-client/graphs/contributors"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do a similar thing in the airbase pom and that is inherited into Trino .. so this would be a consistent approach with it for JavaScript

Copy link
Contributor

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this approach

@mosabua
Copy link
Member Author

mosabua commented Nov 16, 2024

Can @martint @dain or @electrum confirm that it is ok to use the general email..

@regadas
Copy link
Contributor

regadas commented Nov 18, 2024

@mosabua since we gonna do a release soon do you want to move forward with this and change later if it's not ok? let me know how to proceed

@mosabua
Copy link
Member Author

mosabua commented Nov 18, 2024

Yeah .. lets go.

@mosabua mosabua merged commit c0c3ae8 into trinodb:main Nov 18, 2024
4 checks passed
@mosabua mosabua deleted the authors branch November 18, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants