Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update authors information #717

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Update authors information #717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
"description": "Trino client library",
"type": "module",
"author": {
"name": "Filipe Regadas",
"email": "[email protected]",
"url": "https://regadas.dev"
"name": "Trino Javascript contributors",
"email": "[email protected]",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how much emails you used to get via this @regadas .. and also .. this new email is monitored by @martint .. how do we want to handle this in terms of forwarding or whatever

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you might know, how about to use the contributors field?
https://docs.npmjs.com/cli/v10/configuring-npm/package-json#people-fields-author-contributors

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure .. but that would mean we have to maintain each person in the package.jon file in addition. We want to avoid that with this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get a small amount of emails, mainly asking for help.

"url": "https://github.com/trinodb/trino-js-client/graphs/contributors"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do a similar thing in the airbase pom and that is inherited into Trino .. so this would be a consistent approach with it for JavaScript

},
"keywords": [
"trino",
Expand Down