-
Notifications
You must be signed in to change notification settings - Fork 62
Migrate ChatFragment to ViewPager2 #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
2248d97 to
6e4116d
Compare
|
@samfundev I have an idea about how to solve this. Instead of using position numbers manually, what about using an array that sets the number of tabs automatically (depending on whether subscriber emotes are enabled or not)? Like this. I actually tried and got to a good point, but then I got crashes. |
edfa1a5 to
c154f7e
Compare
|
@samfundev I think I have successfully fixed the issue with the tabs. Here's an APK to test. app-debug.zip The only bug left now I think is the scroll-jumping that I mentioned in the other PR. EDIT: Nevermind, fuck. Ok, well, the tablayout and viewpager themselves work fine, but the mood icon still does what I said in the other PR. |
dba12be to
5a69263
Compare
|
I tested the Debug Build and everything seemed to work perfectly (I at least didn't see any bugs, however I tested it without logging in).
|
|
@RickyM7 I'm pretty sure you'll have to log in to test it, as the chatting feature (not to be mistaken with the chat itself) does not appear if you are not logged in. It's a little bit of a hassle (having to input the 2FA code from your email and whatnot), but I have to do it whenever I'm testing as well lol Also the APK is now outdated, so I'll have to fix it |
|
@TacoTheDank Got it! When the Apk is updated I will test correctly. |
9b3095a to
28063a3
Compare
28063a3 to
ec8d4c6
Compare
ec8d4c6 to
5a105a7
Compare
d5f4346 to
c9b9c23
Compare
Brought over from #152
Separated into two PRs to prevent holdup of perfectly good activity viewpager2s.