Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-18271 Rel note updates before pub alpha: Number formats updates, more on RBNF... #4345

Conversation

pedberg-icu
Copy link
Contributor

@pedberg-icu pedberg-icu commented Feb 6, 2025

CLDR-18271

  • This PR completes the ticket.

Rel note updates before pub alpha:

  • In banner, link to current GitHub tag and json tag
  • Number formats updates,
  • More on RBNF...

ALLOW_MANY_COMMITS=true

Copy link

github-actions bot commented Feb 6, 2025

✨ deployed to https://6c6582aa.cldr.pages.dev

@github-actions github-actions bot added the Site Update Updates docs/site label Feb 6, 2025
Comment on lines +83 to +91
(as for use in a table). Some further adjustments were needed ([CLDR-17879](https://unicode-org.atlassian.net/browse/CLDR-17879)):
- Adjust coverage so that these variants are at moderate (not comprehensive) coverage for standard/accounting currency formats with
`numberSystem="latn"`, and so that `alt="alphaNextToNumber"` is at modern (not comprehensive) for oither relevant number systems in
in a locale. Coverage was already correct for other combinations of these attributes with various numberSystems.
- Adjust PathHeader so compact currency for relevant non-Latn number systems in a locale will appear in Survey Tool.
- In root, add an `alt="alphaNextToNumber"` variant for the standard/accounting currency patterns.
- Ensure that in the most commonly-used locales. for all relevant number systems in the locale, the standard/accounting currency
patterns have both `alt="alphaNextToNumber"` and `alt="noCurrency"` variants (inherting as necessary), and the compact currency
formats have the `alt="alphaNextToNumber"` variants.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to state issues in terms on impact on clients of CLDR, not the nitty-gritty internals.

Suggested change
(as for use in a table). Some further adjustments were needed ([CLDR-17879](https://unicode-org.atlassian.net/browse/CLDR-17879)):
- Adjust coverage so that these variants are at moderate (not comprehensive) coverage for standard/accounting currency formats with
`numberSystem="latn"`, and so that `alt="alphaNextToNumber"` is at modern (not comprehensive) for oither relevant number systems in
in a locale. Coverage was already correct for other combinations of these attributes with various numberSystems.
- Adjust PathHeader so compact currency for relevant non-Latn number systems in a locale will appear in Survey Tool.
- In root, add an `alt="alphaNextToNumber"` variant for the standard/accounting currency patterns.
- Ensure that in the most commonly-used locales. for all relevant number systems in the locale, the standard/accounting currency
patterns have both `alt="alphaNextToNumber"` and `alt="noCurrency"` variants (inherting as necessary), and the compact currency
formats have the `alt="alphaNextToNumber"` variants.
(as for use in a table). Gaps in the data coverage showed up, because the translators weren't shown the right values.
Fixes were made in [CLDR-17879](https://unicode-org.atlassian.net/browse/CLDR-17879).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could make this change if you want.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I'm going to go ahead and approve this PR, we can just refine later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I agree. I will merge this now, we can create another PR for further changes.

@pedberg-icu pedberg-icu merged commit dd463ff into main Feb 6, 2025
15 checks passed
@pedberg-icu pedberg-icu deleted the pedberg-icu/cldr-18271/release-notes-updates-before-pub-alpha branch February 6, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Site Update Updates docs/site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants