[WIP] Interactive Legends #4317
Conversation
This commit helps verify that introducing the `init` property for selections should not affect their existing compile- or run-time functionality.
This commit helps verify that introducing the `init` property for selections should not affect their existing compile- or run-time functionality.
…ga/vega-lite into db/interactiveLegend
src/selection.ts
Outdated
| * A boolean determining whether the legend if present should be interactive | ||
| * or not | ||
| */ | ||
| legend?: boolean; |
There was a problem hiding this comment.
Have you consider other alternative syntax for expressing this?
For example, if a selection is projected on X (encodings: ["x"]), what would legend: true do?
Also, if a selection is projected on Color (encodings: ["color"]), should legend be interactive by default?
src/compile/selection/assemble.ts
Outdated
| const newValue = value ? value : {opacity: {value: 0.9}}; | ||
| // To do : Add test case for legends and symbols | ||
| newValue.opacity = [ | ||
| {test: `!(length(data(${store}))) || vlSelectionTest(${store}, {${field}: datum.value})`, ...newValue.opacity}, |
There was a problem hiding this comment.
I recommend using the assembleSelectionPredicate method to generate this test string, so that we're not duplicating important logic. That method may require some minor modification to support the custom second argument to vlSelectionTest.
src/compile/legend/parse.ts
Outdated
| import {defaultTieBreaker, Explicit, makeImplicit, mergeValuesWithExplicit} from '../split'; | ||
| import {UnitModel} from '../unit'; | ||
| import {LegendComponent, LegendComponentIndex} from './component'; | ||
| import * as encode from './encode'; | ||
| import * as properties from './properties'; | ||
|
|
||
| // For MVP, later remove global variable and create new types | ||
| export let selectionOnChannel: any = []; |
There was a problem hiding this comment.
@arvind What would be the best way to send this information to a selection transform function. We can create this list using the model param but has method of a transform does not have a model argument to it. In theory, we can add that argument to the function. Moreover, we can also get this list when the model is being parsed by creating a new method at model.ts. But, both of these methods look like a long stretch to me. I think I am missing something of a very simple solution here. Any thoughts?
arvind
force-pushed
the
as/refactorSelectionCodePaths
branch
3 times, most recently
from
8bf2208 to
fe4b76c
Compare
To be merged after PR #4291
This PR attempts to solve Issue #1657. Legends can now respond to user clicks when
legend: trueis present within a selection containing a project transform.