fix(test): tolerate stale screencast frames in viewport e2e test#1245
Merged
fix(test): tolerate stale screencast frames in viewport e2e test#1245
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Chrome's `Page.startScreencast` `maxWidth`/`maxHeight` are upper bounds, and early frames can arrive before the viewport resize fully takes effect. Instead of asserting exact JPEG dimensions on the first frame, skip frames with stale dimensions and wait for one that matches.
ctate
force-pushed
the
ctate/fix-flaky-stream-viewport-test
branch
from
17e664d to
cc489d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e2e_stream_frame_metadata_respects_custom_viewporttest that intermittently fails on CI with wrong JPEG dimensions (e.g. 361 instead of 600 height). Chrome'sPage.startScreencastmaxWidth/maxHeightare upper bounds, and early frames can arrive before the viewport resize fully takes effect. Instead of asserting exact JPEG dimensions on the first frame, skip frames with stale dimensions and wait for one that matches within the existing 15s deadline.