Skip to content

fix(test): tolerate stale screencast frames in viewport e2e test #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ctate merged 1 commit into from
Apr 16, 2026
+12 −20
Merged

fix(test): tolerate stale screencast frames in viewport e2e test #1245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 12 additions & 20 deletions cli/src/native/e2e_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3950,7 +3950,9 @@ async fn e2e_stream_frame_metadata_respects_custom_viewport() {
.await;
assert_success(&resp);

// Wait for a frame message and verify both metadata and actual image dimensions
// Wait for a frame whose JPEG dimensions match the custom viewport.
// Early frames may arrive before Chrome fully applies the viewport resize,
// so skip frames with stale dimensions rather than failing immediately.
let mut found_frame = false;
let deadline = tokio::time::Instant::now() + tokio::time::Duration::from_secs(15);
while tokio::time::Instant::now() < deadline {
Expand All @@ -3977,28 +3979,18 @@ async fn e2e_stream_frame_metadata_respects_custom_viewport() {
meta
);

// Verify the actual JPEG image dimensions match the custom viewport.
let data_str = parsed
.get("data")
.and_then(|v| v.as_str())
.expect("frame message should include base64-encoded 'data' field");
{
use base64::Engine;
let bytes = base64::engine::general_purpose::STANDARD
.decode(data_str)
.expect("frame data should be valid base64");
let (img_w, img_h) = jpeg_dimensions(&bytes)
.expect("frame data should be a valid JPEG with SOF marker");
assert_eq!(
img_w, 800,
"JPEG image width should match custom viewport, got: {}",
img_w
);
assert_eq!(
img_h, 600,
"JPEG image height should match custom viewport, got: {}",
img_h
);
use base64::Engine;
let bytes = base64::engine::general_purpose::STANDARD
.decode(data_str)
.expect("frame data should be valid base64");
let (img_w, img_h) =
jpeg_dimensions(&bytes).expect("frame data should be a valid JPEG with SOF marker");
if img_w != 800 || img_h != 600 {
continue;
}

found_frame = true;
Expand All @@ -4007,7 +3999,7 @@ async fn e2e_stream_frame_metadata_respects_custom_viewport() {
}
assert!(
found_frame,
"should have received at least one frame message with correct viewport metadata"
"should have received a frame with JPEG dimensions 800x600 within the deadline"
);

// Cleanup
Expand Down
Loading