Skip to content

RSDK-7230: add machine_id to cloud metadata #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 19, 2024
Merged

RSDK-7230: add machine_id to cloud metadata #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
978ae7d
add machine_id to cloud metadata method
maximpertsov Apr 17, 2024
f666454
revert changes related to new type
maximpertsov Apr 19, 2024
19d5be2
flyby
maximpertsov Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions buf.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ deps:
- remote: buf.build
owner: googleapis
repository: googleapis
commit: 7a6bc1e3207144b38e9066861e1de0ff
digest: shake256:d646836485c34192401253703c4e7ce899c826fceec060bf4b2a62c4749bd9976dc960833e134a1f814725e1ffd60b1bb3cf0335a7e99ef0e8cec34b070ffb66
commit: 4ed3bc159a8b4ac68fe253218760d035
digest: shake256:7149cf5e9955c692d381e557830555d4e93f205a0f1b8e2dfdae46d029369aa3fc1980e35df0d310f7cc3b622f93e19ad276769a283a967dd3065ddfd3a40e13
- remote: buf.build
owner: viamrobotics
repository: api
commit: f1167844b03449c996f6df622e3acb0f
digest: shake256:79a474cd634e6fb68f5e7b20bae6fa8f58fd23877f7bcb93232321e27a7f57e76fa62ad708d61bbd592ed2009d2c764408f38bbad9fa0bccb74c63d7fd93151a
commit: 16d95cebecbb47dbba2df34d040bca50
digest: shake256:6a3d4750df0de604c44f44d3bbb73ad78819bdff0ec8353e365eaa8bd6f8b955b304119accbbd66d095122233a1066e3e737e13663b3a7c1d34fb6df71381a96
- remote: buf.build
owner: viamrobotics
repository: goutils
Expand Down
12 changes: 0 additions & 12 deletions src/services/motion/client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,12 @@ describe('moveOnGlobe', () => {
type: 'component',
subtype: 'base',
name: 'myBase',
machinePartId: '',
Copy link
Contributor Author

@maximpertsov maximpertsov Apr 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing a very ironic reference to a different machinePartId field that was removed in an unrelated proto update

};
const expectedMovementSensorName = {
namespace: 'viam',
type: 'component',
subtype: 'movementsensor',
name: 'myMovementsensor',
machinePartId: '',
};
const expectedMotionConfiguration = undefined;
const expectedExtra = {};
Expand Down Expand Up @@ -91,14 +89,12 @@ describe('moveOnGlobe', () => {
type: 'component',
subtype: 'base',
name: 'myBase',
machinePartId: '',
},
{
namespace: 'viam',
type: 'component',
subtype: 'movementsensor',
name: 'myMovementsensor',
machinePartId: '',
}
)
).resolves.toStrictEqual(testExecutionId);
Expand Down Expand Up @@ -137,14 +133,12 @@ describe('moveOnGlobe', () => {
type: 'component',
subtype: 'base',
name: 'myBase',
machinePartId: '',
};
const expectedMovementSensorName = {
namespace: 'viam',
type: 'component',
subtype: 'movementsensor',
name: 'myMovementsensor',
machinePartId: '',
};
const expectedMotionConfiguration = {
obstacleDetectorsList: [
Expand All @@ -154,14 +148,12 @@ describe('moveOnGlobe', () => {
type: 'service',
subtype: 'vision',
name: 'myVisionService',
machinePartId: '',
},
camera: {
namespace: 'viam',
type: 'component',
subtype: 'camera',
name: 'myCamera',
machinePartId: '',
},
},
],
Expand Down Expand Up @@ -227,7 +219,6 @@ describe('stopPlan', () => {
type: 'component',
subtype: 'base',
name: 'myBase',
machinePartId: '',
};
const expectedExtra = {};
const mock = vi
Expand All @@ -253,7 +244,6 @@ describe('stopPlan', () => {
type: 'component',
subtype: 'base',
name: 'myBase',
machinePartId: '',
};
const expectedExtra = { some: 'extra' };
const mock = vi
Expand Down Expand Up @@ -320,7 +310,6 @@ describe('getPlan', () => {
type: 'component',
subtype: 'base',
name: 'myBase',
machinePartId: '',
};
const expectedLastPlanOnly = false;
const expectedExecutionID = '';
Expand Down Expand Up @@ -351,7 +340,6 @@ describe('getPlan', () => {
type: 'component',
subtype: 'base',
name: 'myBase',
machinePartId: '',
};
const expectedLastPlanOnly = true;
const expectedExecutionID = 'some specific executionID';
Expand Down