RSDK-7230: add machine_id to cloud metadata #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheukt
approved these changes
Apr 17, 2024
purplenicole730
approved these changes
Apr 17, 2024
yeah... I might do this differently depending on the answer to my question on the corresponding python sdk change. |
We're gonna do this: viamrobotics/viam-python-sdk#585 (comment) - will update this PR once the corresponding proto API change is live |
maximpertsov
changed the title
maximpertsov
commented
Apr 19, 2024
| @@ -43,7 +43,6 @@ describe('moveOnGlobe', () => { | |||
| type: 'component', | |||
| subtype: 'base', | |||
| name: 'myBase', | |||
| machinePartId: '', | |||
There was a problem hiding this comment.
removing a very ironic reference to a different machinePartId field that was removed in an unrelated proto update
cheukt
approved these changes
Apr 19, 2024
njooma
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change!Not anymore!Add
machineIdto thegetCloudMetadatarobot client method.Also change the return type and renameWe are just deprecating the duplicate field instead.robotPartIdtomachinePartIdfor clarity.Depends on: