Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
436 task guidance node for autopilot #502
base: main
Are you sure you want to change the base?
436 task guidance node for autopilot #502
Changes from 53 commits
917d5bf
cd4d076
7845070
7157c5c
d7dd424
cb2e138
0e8585a
6ab5edf
cd7f490
29c1ad3
07261ee
1fb8b90
d694e89
a007e80
05ff163
f44e105
9ca5b31
15fed69
46455e6
9e7d7ba
fc4780a
79a48b2
acc38cb
bc076c6
9b49170
2e9e1c8
d1987fa
ab21880
fa599fe
b695f1d
03bb8d3
992487d
a4700f8
6ad96af
a78dc87
1bfc2ee
e614471
d0061dc
aa27f9f
fd6db80
2f4cfa9
2d4cadf
8ba17ba
3160f92
afb0a89
845e362
62b1fd8
3b5c8d9
f748524
87309ba
13d1e6f
e6e3e9f
927b03a
3b80ce0
8301782
9467bfc
c0a40b1
e8ab1f4
1c3a504
a210bea
aa1fc7c
6d23e15
1b8e018
a656d6c
68a021b
5ae12ee
bd9d5b4
c4d8530
94775da
0500bca
3bf7576
cf8cd89
76795e0
6886022
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finish the README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what you can do here instead is use math instead of latex
which is written like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe not have space here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already in vortex_utils, cough anders cough, maybe look at that.
If you want to keep this maybe rename surge_vel to u to be more correct with marine standard notations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is max so high? maybe use 3 as max or else you will get the guidance algorithm looking too far ahead and causing a swing too fast.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orca has max speed of 0.3 m/s, maybe set this down
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Third order LOS is not thing, i think its called 3D LOS so call is LOSGuidance maybe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe rename x to filter_state to improve readability. (btw remove the comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the vortex_utils, either use that or copy paste
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vortex_utils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe use:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its better to use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
raw would not be correct here, just call it compute_los_guidance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not even LOS guidance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, remove @ and use np.dot()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure if you need ssa but if you do, move it here:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You dont need this function, just call
compute_raw_los_guidance
andapply_reference_filter
in callback function direct, instead of one function. You can also move theraw_commands = self.compute_raw_los_guidance(current_pos, target_pos)
into thedef apply_reference_filter(self, commands: State) -> State:
and only call the reference model for the complete calculations. This would look much better and make more sense given you code structure.