Feat: Enables override for EmptyGallery in ProductGallery section #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit 3e1bfe2
|
hellofanny
added a commit
to vtex/faststore
that referenced
this pull request
Dec 8, 2023
…#2152) ## What's the purpose of this pull request? - Enables override for `EmptyGallery` in `ProductGallery` section ## How it works? - You can override `EmptyGallery` using `__experimentalEmptyGallery`. ## How to test it? 1. In `packages/core/src/customizations/src/components/overrides/ProductGallery.tsx` change the following code: ``` const override: SectionOverride = { section: SECTION, components: { __experimentalEmptyGallery: { Component: () => <>Empty</> } }, } ``` 2. run `yarn dev` - search for 'a' - You should be able to see "Empty" instead of the `EmtpyGallery` component. <img width="1431" alt="image" src="https://github.com/vtex/faststore/assets/3356699/13084212-d172-4e42-bfcc-3378b74e02be"> ### Starters Deploy Preview vtex-sites/starter.store#303
hellofanny
changed the title
|
closed in favor of #307 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Applies changes from vtex/faststore#2152