Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Enables override for EmptyGallery in ProductGallery section #2152

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

hellofanny
Copy link
Contributor

@hellofanny hellofanny commented Dec 6, 2023

What's the purpose of this pull request?

  • Enables override for EmptyGallery in ProductGallery section

How it works?

  • You can override EmptyGallery using __experimentalEmptyGallery.

How to test it?

  1. In packages/core/src/customizations/src/components/overrides/ProductGallery.tsx

change the following code:

const override: SectionOverride = {
  section: SECTION,
  components: { __experimentalEmptyGallery: { Component: () => <>Empty</> } },
}

  1. run yarn dev
  • search for 'a'
  • You should be able to see "Empty" instead of the EmtpyGallery component.
image

Starters Deploy Preview

vtex-sites/starter.store#303

Copy link

vercel bot commented Dec 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
faststore-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 7, 2023 0:36am

Copy link

codesandbox-ci bot commented Dec 7, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b97a435:

Sandbox Source
Store UI Typescript Configuration

@hellofanny hellofanny changed the title chore: Attempts to override empty gallery Feat: Enables override for EmptyGallery in ProductGallery section Dec 7, 2023
@hellofanny hellofanny marked this pull request as ready for review December 8, 2023 16:11
@hellofanny hellofanny requested a review from a team as a code owner December 8, 2023 16:11
@hellofanny hellofanny requested review from emersonlaurentino and ArthurTriis1 and removed request for a team December 8, 2023 16:11
@hellofanny hellofanny self-assigned this Dec 8, 2023
@hellofanny hellofanny merged commit 1bf2bf2 into main Dec 8, 2023
5 checks passed
@hellofanny hellofanny deleted the chore/empty-gallery-override branch December 8, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants