Skip to content

Comments

Modal Dialog Example: Change dialog title heading elements from H2 to H1#3412

Open
daniel-montalvo wants to merge 1 commit intomainfrom
daniel-montalvo/issue3395
Open

Modal Dialog Example: Change dialog title heading elements from H2 to H1#3412
daniel-montalvo wants to merge 1 commit intomainfrom
daniel-montalvo/issue3395

Conversation

@daniel-montalvo
Copy link
Contributor

@daniel-montalvo daniel-montalvo commented Feb 4, 2026

Fixes #3395

See Preview of modal dialog example where these headings are no longer included in the ToC.


WAI Preview Link (Last built on Wed, 04 Feb 2026 19:23:58 GMT).

…includes headings from example div that should not be included in TOC

Fixes #3395
@mcking65 mcking65 changed the title Change modal headings to h1 Modal Dialog Example: Change dialog title heading elements from H2 to H1 Feb 18, 2026
@a11ydoer a11ydoer self-requested a review February 18, 2026 17:44
@shirsha shirsha self-requested a review February 18, 2026 17:44
@a11ydoer
Copy link
Contributor

The visual review is done during the meeting.

@shirsha
Copy link

shirsha commented Feb 18, 2026

Reviewed all dialogs that have H1. This is not motivated by an accessibility concern. Rather, the generation logic is picking up H2 elements and inserting them into its table of contents. Initially inclined to use H3 elements because those dialogs exist within specific sections, but we will discuss this new issue

Copy link
Contributor

@a11ydoer a11ydoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed PR 3412: Change dialog title heading elements from H2 to H1.

The full IRC log of that discussion <jugglinmike> Topic: PR 3412: Change dialog title heading elements from H2 to H1
<jugglinmike> github: https://github.com//pull/3412
<jugglinmike> Matt_King: I took a quick look at this but didn't submit a review
<jugglinmike> Matt_King: I think we need someone to review this visually to determine whether or not we need to also make CSS changes
<jugglinmike> Jem_: I can do that
<jugglinmike> Matt_King: This impacts the headings inside the dialogs
<jugglinmike> Matt_King: e.g. the dialog for "Add Delivery Address"
<jugglinmike> Siri: Also "Verification Result"
<jugglinmike> Matt_King: And one with a heading that reads "End of the Road"
<jugglinmike> Jem_: I checked with the tag inspector and it is indeed H1
<jugglinmike> Matt_King: If I were to merge this today, do we want to add it to the release we've already prepared?
<jugglinmike> Daniel: I'm fine with that
<jugglinmike> Matt_King: I'll take another look at the actual diff before I merge it, but I'll plan to merge it
<CurtBellew> +1
<jugglinmike> Matt_King: Remember that this is not motivated by an accessibility concern. Rather, the generation logic is picking up H2 elements and inserting them into its table of contents.
<jugglinmike> Siri: Can we add a note to explain why we have made this change?
<Daniel> q+
<jugglinmike> Siri: We usually don't use H1 elements like this
<jugglinmike> Matt_King: That sounds like a new issue: an issue discussing whether or not we recommend using H1 elements within the dialog pattern
<jugglinmike> Daniel: My initial impulse was to use H3 elements because those dialogs exist within specific sections
<jugglinmike> Daniel: We eventually stepped away from that justification, but I do agree that this would be good to discuss in a new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modal Dialog Example: Table of contents includes headings from example div that should not be included in TOC

4 participants