Modal Dialog Example: Change dialog title heading elements from H2 to H1#3412
Open
daniel-montalvo wants to merge 1 commit intomainfrom
Open
Modal Dialog Example: Change dialog title heading elements from H2 to H1#3412daniel-montalvo wants to merge 1 commit intomainfrom
daniel-montalvo wants to merge 1 commit intomainfrom
Conversation
…includes headings from example div that should not be included in TOC Fixes #3395
Contributor
|
The visual review is done during the meeting. |
|
Reviewed all dialogs that have H1. This is not motivated by an accessibility concern. Rather, the generation logic is picking up H2 elements and inserting them into its table of contents. Initially inclined to use H3 elements because those dialogs exist within specific sections, but we will discuss this new issue |
shirsha
approved these changes
Feb 18, 2026
Member
|
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<jugglinmike> Topic: PR 3412: Change dialog title heading elements from H2 to H1<jugglinmike> github: https://github.com//pull/3412 <jugglinmike> Matt_King: I took a quick look at this but didn't submit a review <jugglinmike> Matt_King: I think we need someone to review this visually to determine whether or not we need to also make CSS changes <jugglinmike> Jem_: I can do that <jugglinmike> Matt_King: This impacts the headings inside the dialogs <jugglinmike> Matt_King: e.g. the dialog for "Add Delivery Address" <jugglinmike> Siri: Also "Verification Result" <jugglinmike> Matt_King: And one with a heading that reads "End of the Road" <jugglinmike> Jem_: I checked with the tag inspector and it is indeed H1 <jugglinmike> Matt_King: If I were to merge this today, do we want to add it to the release we've already prepared? <jugglinmike> Daniel: I'm fine with that <jugglinmike> Matt_King: I'll take another look at the actual diff before I merge it, but I'll plan to merge it <CurtBellew> +1 <jugglinmike> Matt_King: Remember that this is not motivated by an accessibility concern. Rather, the generation logic is picking up H2 elements and inserting them into its table of contents. <jugglinmike> Siri: Can we add a note to explain why we have made this change? <Daniel> q+ <jugglinmike> Siri: We usually don't use H1 elements like this <jugglinmike> Matt_King: That sounds like a new issue: an issue discussing whether or not we recommend using H1 elements within the dialog pattern <jugglinmike> Daniel: My initial impulse was to use H3 elements because those dialogs exist within specific sections <jugglinmike> Daniel: We eventually stepped away from that justification, but I do agree that this would be good to discuss in a new issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3395
See Preview of modal dialog example where these headings are no longer included in the ToC.
WAI Preview Link (Last built on Wed, 04 Feb 2026 19:23:58 GMT).