Skip to content

Modal Dialog Example: Change dialog title heading elements from H2 to H1 #3412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daniel-montalvo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Modal Dialog Example: Change dialog title heading elements from H2 to H1 #3412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions content/patterns/dialog-modal/examples/dialog.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
<button type="button" onclick="openDialog('dialog1', this)">Add Delivery Address</button>
<div id="dialog_layer" class="dialogs">
<div role="dialog" id="dialog1" aria-labelledby="dialog1_label" aria-modal="true" class="hidden">
<h2 id="dialog1_label" class="dialog_label">Add Delivery Address</h2>
<h1 id="dialog1_label" class="dialog_label">Add Delivery Address</h1>

Check warning on line 55 in content/patterns/dialog-modal/examples/dialog.html

View workflow job for this annotation

GitHub Actions / lint-html 

Consider using the “h1” element as a top-level heading only (all “h1” elements are treated as top-level headings by many screen readers and other tools).

Check warning on line 55 in content/patterns/dialog-modal/examples/dialog.html

View workflow job for this annotation

GitHub Actions / lint-html 

Consider using the “h1” element as a top-level heading only (all “h1” elements are treated as top-level headings by many screen readers and other tools).
<div class="dialog_form">
<div class="dialog_form_item">
<label>
Expand Down Expand Up @@ -96,7 +96,7 @@

<!-- Second modal to open on top of the first modal -->
<div id="dialog2" role="dialog" aria-labelledby="dialog2_label" aria-describedby="dialog2_desc" aria-modal="true" class="hidden">
<h2 id="dialog2_label" class="dialog_label">Verification Result</h2>
<h1 id="dialog2_label" class="dialog_label">Verification Result</h1>

Check warning on line 99 in content/patterns/dialog-modal/examples/dialog.html

View workflow job for this annotation

GitHub Actions / lint-html 

Consider using the “h1” element as a top-level heading only (all “h1” elements are treated as top-level headings by many screen readers and other tools).

Check warning on line 99 in content/patterns/dialog-modal/examples/dialog.html

View workflow job for this annotation

GitHub Actions / lint-html 

Consider using the “h1” element as a top-level heading only (all “h1” elements are treated as top-level headings by many screen readers and other tools).
<div id="dialog2_desc" class="dialog_desc">
<p tabindex="-1" id="dialog2_para1">
This is just a demonstration.
Expand Down Expand Up @@ -148,7 +148,7 @@

<!-- Dialog that replaces dialog 1. -->
<div id="dialog3" role="dialog" aria-labelledby="dialog3_label" aria-describedby="dialog3_desc" aria-modal="true" class="hidden">
<h2 id="dialog3_label" class="dialog_label">Address Added</h2>
<h1 id="dialog3_label" class="dialog_label">Address Added</h1>

Check warning on line 151 in content/patterns/dialog-modal/examples/dialog.html

View workflow job for this annotation

GitHub Actions / lint-html 

Consider using the “h1” element as a top-level heading only (all “h1” elements are treated as top-level headings by many screen readers and other tools).

Check warning on line 151 in content/patterns/dialog-modal/examples/dialog.html

View workflow job for this annotation

GitHub Actions / lint-html 

Consider using the “h1” element as a top-level heading only (all “h1” elements are treated as top-level headings by many screen readers and other tools).
<p id="dialog3_desc" class="dialog_desc">
The address you provided has been added to your list of delivery addresses.
It is ready for immediate use.
Expand All @@ -160,7 +160,7 @@
</div>

<div id="dialog4" role="dialog" aria-labelledby="dialog4_label" aria-describedby="dialog4_desc" class="hidden" aria-modal="true">
<h2 id="dialog4_label" class="dialog_label">End of the Road!</h2>
<h1 id="dialog4_label" class="dialog_label">End of the Road!</h1>

Check warning on line 163 in content/patterns/dialog-modal/examples/dialog.html

View workflow job for this annotation

GitHub Actions / lint-html 

Consider using the “h1” element as a top-level heading only (all “h1” elements are treated as top-level headings by many screen readers and other tools).

Check warning on line 163 in content/patterns/dialog-modal/examples/dialog.html

View workflow job for this annotation

GitHub Actions / lint-html 

Consider using the “h1” element as a top-level heading only (all “h1” elements are treated as top-level headings by many screen readers and other tools).
<p id="dialog4_desc" class="dialog_desc">You activated a fake link or button that goes nowhere! The link or button is present for demonstration purposes only.</p>
<div class="dialog_form_actions">
<button type="button" id="dialog4_close_btn" onclick="closeDialog(this)">Close</button>
Expand Down
Loading