Content change: Add definitions for MLOperand's shape and dataType #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will conflict with some other PRs in flight so for now just review as "is this an improvement?" |
|
Looks good. |
inexorabletash
force-pushed
the
content-operand-properties
branch
from
5da50b2 to
f8e91a2
Compare
huningxin
reviewed
Feb 7, 2024
Simplify text that digs the dimensions and dataType out of an MLOperand's [[descriptor]] by introducing definitions, and use them consistently. Also simplify the definition for MLOperand's rank, and use it in more places.
inexorabletash
force-pushed
the
content-operand-properties
branch
from
f8e91a2 to
5d296a7
Compare
Closed
fdwr
reviewed
Feb 9, 2024
fdwr
approved these changes
Feb 9, 2024
|
@inexorabletash : Please promote from draft when ready. 0D is merged. |
|
Okay, merged the changes from main. I didn't force-push so the history has a merge commit. Hopefully I did it right! Should be ready for review. |
github-actions bot
added a commit
that referenced
this pull request
Feb 13, 2024
) SHA: 8503e24 Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
inexorabletash
added a commit
to inexorabletash/webnn
that referenced
this pull request
Feb 14, 2024
Old a busted: ... the [=property=] of |object| ... New hotness: ... |object|'s [=property=] ... Discussed in webmachinelearning#555 (comment)
inexorabletash
added a commit
to inexorabletash/webnn
that referenced
this pull request
Feb 14, 2024
Old and busted: ... the [=property=] of |object| ... New hotness: ... |object|'s [=property=] ... Discussed in webmachinelearning#555 (comment)
anssiko
pushed a commit
that referenced
this pull request
Feb 15, 2024
…565) * Bug fix: Correct "rank of op's shape" to just "rank of op" MLOperands have a rank; the shape just has a size. * Wording: Use shorter possessive form for abstract object properties Old and busted: ... the [=property=] of |object| ... New hotness: ... |object|'s [=property=] ... Discussed in #555 (comment) * Bug fix: Dedupe some words I noticed "then then" in the previous commit and searched for similar glitches to fix. * Bug fix: Incorrect referencing operand properties * Erroneously referencing descriptor properties, but directly against an operand. This can be fixed by using the shape and dataType shortcuts. (6 cases) * Simplifications where an operand's shape shortcut could be used. (3 cases)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify text that digs the dimensions and dataType out of an MLOperand's [[descriptor]] by introducing definitions, and use them consistently.
Also simplify the definition for MLOperand's rank, and use it in more places.
Preview | Diff