-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Operator set wave 3 #805
Operator set wave 3 #805
Conversation
Another "TODO" - the new ops need "constraints" tables |
Note from discussion w/ @a-sully - CoreML has restrictions on the dequantize op that we'll need to think about.
Re-emphasizing that dequantizing (u)int4 in CoreML is extremely limited (input must be const). @mwyrzykowski - any thoughts about how we can handle the proposed ops efficiently? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial pass.
Added data type tables.
Thanks - will address more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed most feedback (not output shape calculation and blockwise compatible definition).
index.bs
Outdated
</details> | ||
|
||
### scatterElements ### {#api-mlgraphbuilder-scatterelements} | ||
Scatter values from the updates tensor along an axis according to the indices in place of the input tensor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 What about "atop" in-place of inplace? Or in-place of a copy of?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another batch of feedback; I didn't make it all the way through the PR though.
…ements examples, fix flatten on edge conditions
Co-authored-by: Joshua Bell <[email protected]>
Co-authored-by: Joshua Bell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌊 Huge thank you to @fdwr for this significant op set update and @inexorabletash @huningxin, other participants for contributions and comments, in total close to 150 over 200!
As discussed, we'll periodically seek TAG review for significant changes to the spec. This spec update complemented with a demonstration of implementation experience across multiple backends and OSes will be brought to the TAG's attention alongside other significant changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, noted a few more places where an arg reference should be linkified rather than just styled.
👏 Co-authored-by: Joshua Bell <[email protected]> Co-authored-by: Ningxin Hu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should address all of Ningxin and Joshua's last feedback. 🤞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@inexorabletash Want to take one more pass? |
I've been following along, still LGTM. Merge away! |
SHA: 6e19654 Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Adds the following operators, per #375 (comment) Support for transformers:
slice
operator #772reverse
operator #773Todos
RemainingEither done now, or deferred to separate CR/issue:expand
to support blockwiseAPI
Preview | Diff