Add USING_ETH workflow + fix eth test cases #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadenzipfel
reviewed
Oct 23, 2024
Comment on lines
+60
to
+66
| - name: Run forge tests with usingEth (true) | ||
| run: | | ||
| export USING_ETH=TRUE | ||
| export FEE=0 | ||
| export PROTOCOL_FEE=0 | ||
| forge test -vvv --via-ir | ||
| id: test3 |
There was a problem hiding this comment.
Would be good to add combinations with the other runs, i.e. with fees and using eth
kinrezC
added a commit
that referenced
this pull request
Oct 23, 2024
* Add USING_ETH workflow + fix eth test cases (#154) * Add revert swap utils
kinrezC
added a commit
that referenced
this pull request
Oct 23, 2024
* Revert swap utils (#152) * Add USING_ETH workflow + fix eth test cases (#154) --------- Co-authored-by: clemlak <[email protected]> Co-authored-by: Clément Lakhal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #127